Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: LICENSE #29

Merged
merged 3 commits into from
Sep 23, 2021
Merged

docs: LICENSE #29

merged 3 commits into from
Sep 23, 2021

Conversation

EA-pbu
Copy link
Contributor

@EA-pbu EA-pbu commented Sep 21, 2021

added MIT License file

added MIT License file
@EA-pbu
Copy link
Contributor Author

EA-pbu commented Sep 21, 2021

Hi @zposten !
Awesome work on creating this useful package!
Would you mind open-sourcing it with an MIT license template so that the others can legally use it for their own purposes?
I created one LICENSE file with MIT template with current year and your name in it.
It's totally up to you wether you consider adding a license to your project or not.

Thanks again!

@EA-pbu EA-pbu changed the title Create LICENSE add: LICENSE Sep 21, 2021
Add LICENSE file
@EA-pbu EA-pbu changed the title add: LICENSE fix: LICENSE Sep 21, 2021
@EA-pbu EA-pbu changed the title fix: LICENSE add: LICENSE Sep 21, 2021
@EA-pbu EA-pbu changed the title add: LICENSE docs: LICENSE Sep 21, 2021
@0livare
Copy link
Owner

0livare commented Sep 22, 2021

Hey @EA-pbu, thanks for the PR!

My intention is definitely for this package to be fully open source. The package.json's license field has a value of "MIT". Is there a reason that that alone does not suffice to specify the license?

@EA-pbu
Copy link
Contributor Author

EA-pbu commented Sep 23, 2021

Hi @zposten !
Appreciate your swift response, thanks a lot.

Indeed you have mentioned MIT license in package.json . By no means I claim to have a deep knowledge of all legal peculiarities of open-source projects.
I'm only coming from suggestion that sometimes people would like to see actual license file that includes the details for legal use of your code. And mentioning "MIT" in package.json is not really informative in such case.
And other reason that I think it may be useful to include a LICENSE file is just because all popular npm packages are having
actual LICENSE files in their repositories. Big corporations are behind these packages and I think they have a reason including an actual LICENSE file to their repositories on top of mentioning it swiftly in packages.json

You can have a look:
https://github.com/expressjs/express
https://github.com/facebook/jest
https://github.com/Microsoft/TypeScript

@0livare
Copy link
Owner

0livare commented Sep 23, 2021

@EA-pbu Good points all! Thanks for discussing it with me. I agree we should add the LICENSE file.

Could you possibly add my email to the copyright line please? Then I'll merge this in publish a new version

Copyright (c) 2021 Zach Posten <[email protected]>

email included
@EA-pbu
Copy link
Contributor Author

EA-pbu commented Sep 23, 2021

sure! included your email

@0livare
Copy link
Owner

0livare commented Sep 23, 2021

Thank you!

@0livare 0livare merged commit 1b69fca into 0livare:master Sep 23, 2021
@0livare
Copy link
Owner

0livare commented Sep 23, 2021

@EA-pbu Just a heads up v0.0.14 is out with all these changes. Thanks so much for you contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants