Merge pull request brave#644 from brave/remote-require

remove electron remote.require api
102286545 · Aug 28, 2018 · bdab7f9 · bdab7f9
2 parents f256433 + a38183c
commit bdab7f9
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/lib/browser/rpc-server.js b/lib/browser/rpc-server.js
@@ -227,14 +227,6 @@ const callFunction = function (event, func, caller, args) {
   }
 }
 
-ipcMain.on('ELECTRON_BROWSER_REQUIRE', function (event, module) {
-  try {
-    event.returnValue = valueToMeta(event.sender, process.mainModule.require(module))
-  } catch (error) {
-    event.returnValue = exceptionToMeta(error)
-  }
-})
-
 ipcMain.on('ELECTRON_BROWSER_GET_BUILTIN', function (event, module) {
   try {
     event.returnValue = valueToMeta(event.sender, electron[module])

diff --git a/lib/renderer/api/remote.js b/lib/renderer/api/remote.js
@@ -292,10 +292,6 @@ ipcRenderer.on('ELECTRON_RENDERER_RELEASE_CALLBACK', function (event, id) {
 
 var binding = {}
 
-binding.require = function (module) {
-  return metaToValue(ipcRenderer.sendSync('ELECTRON_BROWSER_REQUIRE', module))
-}
-
 // Alias to remote.require('electron').xxx.
 binding.getBuiltin = function (module) {
   return metaToValue(ipcRenderer.sendSync('ELECTRON_BROWSER_GET_BUILTIN', module))