Skip to content

feat: Add connection pool connection check parameters #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025

Conversation

shaohuzhang1
Copy link
Contributor

feat: Add connection pool connection check parameters

@@ -118,7 +118,8 @@ def get_db_setting(self) -> dict:
"POOL_SIZE": 20,
"MAX_OVERFLOW": int(self.get('DB_MAX_OVERFLOW')),
"RECYCLE": 1800,
"TIMEOUT": 30
"TIMEOUT": 30,
'PRE_PING': True
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code looks mostly correct and does not contain any major issues. However, I would suggest a few minor optimizations and changes:

  1. Consistency in Key Capitalization: Ensure that all dictionary keys use consistent capitalization (or lowercase), such as pool_size, max_overflow, etc.

  2. Comments: Consider adding comments to explain each key-value pair for clarity. This is just a suggestion and doesn't affect the functionality of the function.

Here's the modified version with these suggestions:

@@ -118,7 +118,8 @@ def get_db_setting(self) -> dict:
                 "POOL_SIZE": 20,
                 "MAX_OVERFLOW": int(self.get('DB_MAX_OVERFLOW')),
                 "RECYCLE": 1800,
-                "TIMEOUT": 30
+                "TIMEOUT": 30,
+                'PRE_PING': True
             }
         }

If you need further assistance or have more specific changes in mind, feel free to ask!

@shaohuzhang1 shaohuzhang1 merged commit bb9bc95 into v1 Aug 21, 2025
3 of 4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v1@feat_pool branch August 21, 2025 02:22
Copy link

f2c-ci-robot bot commented Aug 21, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

f2c-ci-robot bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant