Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: integrate metadata information to config #353

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

1chooo
Copy link
Owner

@1chooo 1chooo commented Oct 4, 2024

No description provided.

1chooo added 6 commits October 4, 2024 22:52
- Move the title configuration from the metadata object to the config object in the web page component.
- Update the document title in the Contact, About, Portfolio, and Resume pages to include the title from the config object.
- Remove unused imports and fix formatting issues.
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
1chooo-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 4:42pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
1chooo-com-docs ⬜️ Skipped (Inspect) Oct 4, 2024 4:42pm

@1chooo 1chooo self-assigned this Oct 4, 2024
@1chooo 1chooo added the enhancement New feature or request label Oct 4, 2024
@1chooo 1chooo added this to the October 2024 milestone Oct 4, 2024
@1chooo 1chooo linked an issue Oct 4, 2024 that may be closed by this pull request
@1chooo 1chooo merged commit a18af28 into main Oct 4, 2024
4 checks passed
@1chooo 1chooo deleted the refactor/integrate-title-description-keyword-to-config branch October 4, 2024 16:42
Copy link
Owner Author

@1chooo 1chooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to come out with the better to write metadata because the current method we are constrained by use client;.

related: #352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Integrate title, description, keywords to config
1 participant