Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): slayer skill #796

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

hex-agon
Copy link
Contributor

@hex-agon hex-agon commented Aug 24, 2024

Some initial scripts related to the slayer skill, for whenever we get there...

Demo: https://streamable.com/9djx45

Things that are done:

  • Slayer tasks up to around june 2006
  • Slayer introduction chat
  • Generic slayer master chat
  • Slayer gem chat

There are still things that need to be done:

  • The slayer skill does not exist, it currently gives runecraft exp
  • The slayer master shop
  • The current slayer task 'table' is just a placeholder and there's only one
  • The task extra checks are placeholders as the quest varp/varbits do not exist yet
  • Npc/Obj types
  • Slayer npcs combat scripts
  • Slayer npcs spawns

This PR only works if you're running the server with BUILD_VERIFY=false as it's technically adding 'custom' content

@hex-agon hex-agon marked this pull request as draft August 24, 2024 00:23
@FlenarnTemp
Copy link
Collaborator

This looks great, but I'm not 100% sure on if this is something we would necessarily ever merge in this repository. As of right now, it'll most likely be another half year, if not more, before we even leave the 225 revision, and another good chunk of time before we're at January 2005 when Slayer is introduced.

This might be more suitable to close, and re-open when the time comes with focus being on content we have in the current revision, even more so as it's a bit unclear how the Github structure will be once we consider 225 complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants