Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time comparison #49

Merged
merged 3 commits into from
Jul 29, 2014
Merged

Fix time comparison #49

merged 3 commits into from
Jul 29, 2014

Conversation

fcavalieri
Copy link
Contributor

fixes #26

@fcavalieri
Copy link
Contributor Author

@MatthiasBrantner @wcandillon Hi guys, this is ready for review. This fixes the reported bug, but our implementation is not handling correctly indeterminate comparisons (see: http://www.w3.org/TR/xmlschema-2/#dateTime @ 3.2.7.4.)
image
I created a bug for these other issues.

@MatthiasBrantner
Copy link
Contributor

@wcandillon I leave it to you. You know the corresponding test better.

@wcandillon
Copy link
Contributor

@fcavalieri it doesn't appear to fix the w3c test suite: https://travis-ci.org/28msec/zorba/builds/31153294

@fcavalieri
Copy link
Contributor Author

Can you give me a test/expected result for the remaining issue?

On Tue, Jul 29, 2014 at 6:50 PM, William Candillon <[email protected]

wrote:

@fcavalieri https://github.com/fcavalieri it doesn't appear to fix the
w3c test suite: https://travis-ci.org/28msec/zorba/builds/31153294


Reply to this email directly or view it on GitHub
#49 (comment).

wcandillon pushed a commit that referenced this pull request Jul 29, 2014
@wcandillon wcandillon merged commit 0c1d781 into master Jul 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timezone Bug
3 participants