Skip to content

Commit

Permalink
cifs: double lock in cifs_reconnect_tcon()
Browse files Browse the repository at this point in the history
This lock was supposed to be an unlock.

Fixes: 6cc041e ("cifs: avoid races in parallel reconnects in smb1")
Signed-off-by: Dan Carpenter <[email protected]>
Reviewed-by: Paulo Alcantara (SUSE) <[email protected]>
Signed-off-by: Steve French <[email protected]>
  • Loading branch information
error27 authored and Steve French committed Apr 7, 2023
1 parent d19342c commit 4f5d5b3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/cifs/cifssmb.c
Original file line number Diff line number Diff line change
@@ -120,7 +120,7 @@ cifs_reconnect_tcon(struct cifs_tcon *tcon, int smb_command)
spin_lock(&server->srv_lock);
if (server->tcpStatus == CifsNeedReconnect) {
spin_unlock(&server->srv_lock);
mutex_lock(&ses->session_mutex);
mutex_unlock(&ses->session_mutex);

if (tcon->retry)
goto again;

0 comments on commit 4f5d5b3

Please sign in to comment.