Skip to content

Commit

Permalink
dt-bindings: usb: Correct and extend FOTG210 schema
Browse files Browse the repository at this point in the history
It turns out that this IP block exists in at least two
incarnations: FOTG200 and FOTG210. The one in the Gemini
is FOTG200, so add the variants and rectify the binding
for Gemini.

This affects things such as the placement of certain
registers.

It remains to be seen how similar this block is to the
third USB block from Faraday, FUSB220.

Signed-off-by: Linus Walleij <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
linusw authored and gregkh committed Jan 19, 2023
1 parent 82b0417 commit 8867258
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions Documentation/devicetree/bindings/usb/faraday,fotg210.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
$id: http://devicetree.org/schemas/usb/faraday,fotg210.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

title: Faraday Technology FOTG210 HS OTG USB 2.0 controller
title: Faraday Technology FOTG200 series HS OTG USB 2.0 controller

maintainers:
- Linus Walleij <[email protected]>
Expand All @@ -17,10 +17,11 @@ allOf:
properties:
compatible:
oneOf:
- const: faraday,fotg200
- const: faraday,fotg210
- items:
- const: cortina,gemini-usb
- const: faraday,fotg210
- const: faraday,fotg200

reg:
maxItems: 1
Expand Down Expand Up @@ -66,7 +67,7 @@ examples:
#include <dt-bindings/clock/cortina,gemini-clock.h>
#include <dt-bindings/reset/cortina,gemini-reset.h>
usb0: usb@68000000 {
compatible = "cortina,gemini-usb", "faraday,fotg210";
compatible = "cortina,gemini-usb", "faraday,fotg200";
reg = <0x68000000 0x1000>;
interrupts = <10 IRQ_TYPE_LEVEL_HIGH>;
resets = <&syscon GEMINI_RESET_USB0>;
Expand Down

0 comments on commit 8867258

Please sign in to comment.