Skip to content

Commit

Permalink
backlight: arcxcnn: Use backlight helper
Browse files Browse the repository at this point in the history
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.

Signed-off-by: Stephen Kitt <[email protected]>
Reviewed-by: Sam Ravnborg <[email protected]>
Reviewed-by: Daniel Thompson <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
skitt authored and lag-linaro committed Feb 22, 2023
1 parent 3a396f9 commit fef0b89
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/video/backlight/arcxcnn_bl.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,9 @@ static int arcxcnn_set_brightness(struct arcxcnn *lp, u32 brightness)
static int arcxcnn_bl_update_status(struct backlight_device *bl)
{
struct arcxcnn *lp = bl_get_data(bl);
u32 brightness = bl->props.brightness;
u32 brightness = backlight_get_brightness(bl);
int ret;

if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
brightness = 0;

ret = arcxcnn_set_brightness(lp, brightness);
if (ret)
return ret;
Expand Down

0 comments on commit fef0b89

Please sign in to comment.