Apply suggestions from code review

call add_transform directly instead of wrapping it into prepare_outro Co-Authored-By: Rich Harris <[email protected]>
43081j · Jun 3, 2019 · ef74838 · ef74838
1 parent 068a4b7
commit ef74838
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/compiler/compile/render-dom/wrappers/Element/index.ts b/src/compiler/compile/render-dom/wrappers/Element/index.ts
@@ -778,7 +778,7 @@ export default class ElementWrapper extends Wrapper {
 		block.builders.fix.add_block(deindent`
 			@fix_position(${this.var});
 			${stop_animation}();
-			${outro && `@prepare_outro(${this.var}, ${rect});`}
+			${outro && `@add_transform(${this.var}, ${rect});`}
 		`);
 
 		const params = this.node.animation.expression ? this.node.animation.expression.render(block) : '{}';

diff --git a/src/runtime/internal/animations.ts b/src/runtime/internal/animations.ts
@@ -94,7 +94,7 @@ export function fix_position(node: Element & ElementCSSInlineStyle) {
 	}
 }
 
-function add_transform(node: Element & ElementCSSInlineStyle, a: PositionRect) {
+export function add_transform(node: Element & ElementCSSInlineStyle, a: PositionRect) {
 	const b = node.getBoundingClientRect();
 
 	if (a.left !== b.left || a.top !== b.top) {