Merge pull request Expensify#13559 from Expensify/stites-fixShellLint

Fix Shell Lint

.github/scripts/buildActions.sh

@@ -42,15 +42,15 @@ for ((i=0; i < ${#GITHUB_ACTIONS[@]}; i++)); do
 
   # Build the action in the background
   ncc build "$ACTION" -o "$ACTION_DIR" &
-  ASYNC_BUILDS[$i]=$!
+  ASYNC_BUILDS[i]=$!
 done
 
 for ((i=0; i < ${#GITHUB_ACTIONS[@]}; i++)); do
   ACTION=${GITHUB_ACTIONS[$i]}
   ACTION_DIR=$(dirname "$ACTION")
 
   # Wait for the background build to finish
-  wait ${ASYNC_BUILDS[$i]}
+  wait "${ASYNC_BUILDS[$i]}"
 
   # Prepend the warning note to the top of the compiled file
   OUTPUT_FILE="$ACTION_DIR/index.js"

.github/scripts/validateActionsAndWorkflows.sh

@@ -36,7 +36,7 @@ info 'Validating actions and workflows against their JSON schemas...'
 for ((i=0; i < ${#ACTIONS[@]}; i++)); do
   ACTION=${ACTIONS[$i]}
   ajv -s ./tempSchemas/github-action.json -d "$ACTION" --strict=false &
-  ASYNC_PROCESSES[$i]=$!
+  ASYNC_PROCESSES[i]=$!
 done
 
 for ((i=0; i < ${#WORKFLOWS[@]}; i++)); do
@@ -48,12 +48,12 @@ for ((i=0; i < ${#WORKFLOWS[@]}; i++)); do
     fi
 
   ajv -s ./tempSchemas/github-workflow.json -d "$WORKFLOW" --strict=false &
-  ASYNC_PROCESSES[${#ACTIONS[@]} + $i]=$!
+  ASYNC_PROCESSES[${#ACTIONS[@]} + i]=$!
 done
 
 # Wait for the background builds to finish
 for PID in "${ASYNC_PROCESSES[@]}"; do
-  wait $PID
+  wait "$PID"
   RESULT=$?
   if [[ $RESULT != 0 ]]; then
     EXIT_CODE=$RESULT