No longer setting minimal memory per thread

I had previously assumed that minimizing the amount of memory per thread would be valuable, since our system runs so lean, I didn't need megabytes per thread. Unfortunately this caused the tests on Linux to StackOverflow when going through relatively ordinary numbers of stackframes. I was so perplexed. But when I used "Git bisect", I was able to narrow it down to the commit where I added -Xss 180k (set the threads in the JVM to only use 180k of memory each).
7ep · Apr 21, 2021 · ea163b3 · ea163b3
1 parent 27a37fa
commit ea163b3
Show file tree

Hide file tree

Showing 12 changed files with 11 additions and 5 deletions.
diff --git a/build.gradle b/build.gradle
@@ -206,9 +206,6 @@ tasks.withType(Test).configureEach {
     // it's possible to run in parallel, but so far the speed gains aren't obvious, turning off for now
     // maxParallelForks = Runtime.runtime.availableProcessors().intdiv(2) ?: 1
 
-    // set JVM arguments for the test JVM(s)
-    jvmArgs '-Xss180k'
-
     jacoco {
         includes = ['coverosR3z.*']
     }

diff --git a/docs/operations/restart.sh b/docs/operations/restart.sh
@@ -42,7 +42,7 @@ echo "System has shutdown"
 # minimize memory use where we can
 
 echo "Starting system"
-java -Djavax.net.ssl.keyStore=keystore -Djavax.net.ssl.keyStorePassword=passphrase -Xss180k -jar r3z.jar -h renomad.com  &>>r3z.log &
+java -Djavax.net.ssl.keyStore=keystore -Djavax.net.ssl.keyStorePassword=passphrase -jar r3z.jar -h renomad.com  &>>r3z.log &
 
 # get the process id, pop it in a file
 # (we'll use this to stop the process later)

diff --git a/docs/operations/start.sh b/docs/operations/start.sh
@@ -14,7 +14,7 @@ cd $MYDIR
 # minimize memory use where we can
 
 # run the timekeeping application
-java -Djavax.net.ssl.keyStore=keystore -Djavax.net.ssl.keyStorePassword=passphrase -Xss180k -jar r3z.jar -h renomad.com  &>>r3z.log &
+java -Djavax.net.ssl.keyStore=keystore -Djavax.net.ssl.keyStorePassword=passphrase -jar r3z.jar -h renomad.com  &>>r3z.log &
 
 # get the process id, pop it in a file (we'll use this to stop the process later)
 echo $! > pid

diff --git a/...ormance_archive/granular_tests/should_get_responses_from_the_database_quickly_PERFORMANCE b/...ormance_archive/granular_tests/should_get_responses_from_the_database_quickly_PERFORMANCE
@@ -398,3 +398,4 @@
 2021-04-16	numberOfEmployees: 30	numberProjects: 30	numberOfDays: 31	time: 115
 2021-04-17	numberOfEmployees: 30	numberProjects: 30	numberOfDays: 31	time: 84
 2021-04-17	numberOfEmployees: 30	numberProjects: 30	numberOfDays: 31	time: 100
+2021-04-21	numberOfEmployees: 30	numberProjects: 30	numberOfDays: 31	time: 112
diff --git a/docs/performance_archive/granular_tests/testEnterTimeAPI_PERFORMANCE b/docs/performance_archive/granular_tests/testEnterTimeAPI_PERFORMANCE
@@ -364,3 +364,4 @@
 2021-04-16	requests: 200	time: 16 milliseconds
 2021-04-17	requests: 200	time: 7 milliseconds
 2021-04-17	requests: 200	time: 12 milliseconds
+2021-04-21	requests: 200	time: 25 milliseconds
diff --git a/docs/performance_archive/granular_tests/testEnterTimeReal_PERFORMANCE b/docs/performance_archive/granular_tests/testEnterTimeReal_PERFORMANCE
@@ -396,3 +396,4 @@
 2021-04-16	numberThreads: 5	numberRequests: 200	time: 186
 2021-04-17	numberThreads: 5	numberRequests: 200	time: 224
 2021-04-17	numberThreads: 5	numberRequests: 200	time: 182
+2021-04-21	numberThreads: 5	numberRequests: 200	time: 233
diff --git a/docs/performance_archive/granular_tests/testHomepage_PERFORMANCE b/docs/performance_archive/granular_tests/testHomepage_PERFORMANCE
@@ -381,3 +381,4 @@
 2021-04-16	numberOfThreads: 10	numberOfRequests: 300	time: 96
 2021-04-17	numberOfThreads: 10	numberOfRequests: 300	time: 109
 2021-04-17	numberOfThreads: 10	numberOfRequests: 300	time: 102
+2021-04-21	numberOfThreads: 10	numberOfRequests: 300	time: 129
diff --git a/docs/performance_archive/granular_tests/testShouldParseData_PERFORMANCE b/docs/performance_archive/granular_tests/testShouldParseData_PERFORMANCE
@@ -390,3 +390,4 @@
 2021-04-16	numberOfParsings: 1000	time: 2
 2021-04-17	numberOfParsings: 1000	time: 0
 2021-04-17	numberOfParsings: 1000	time: 0
+2021-04-21	numberOfParsings: 1000	time: 2
diff --git a/docs/performance_archive/granular_tests/testShouldWriteAndReadToDisk_PERFORMANCE b/docs/performance_archive/granular_tests/testShouldWriteAndReadToDisk_PERFORMANCE
@@ -360,3 +360,4 @@
 2021-04-16	numberOfEmployees: 20	numberOfProjects: 10	numberOfDays: 31	totalTime: 3066
 2021-04-17	numberOfEmployees: 20	numberOfProjects: 10	numberOfDays: 31	totalTime: 3000
 2021-04-17	numberOfEmployees: 20	numberOfProjects: 10	numberOfDays: 31	totalTime: 3055
+2021-04-21	numberOfEmployees: 20	numberOfProjects: 10	numberOfDays: 31	totalTime: 3081
diff --git a/docs/performance_archive/granular_tests/testViewStaticContentAuthenticated_PERFORMANCE b/docs/performance_archive/granular_tests/testViewStaticContentAuthenticated_PERFORMANCE
@@ -371,3 +371,4 @@
 2021-04-16	numberThreads: 20	numberRequests: 500	time: 2085
 2021-04-17	numberThreads: 20	numberRequests: 500	time: 2046
 2021-04-17	numberThreads: 20	numberRequests: 500	time: 2086
+2021-04-21	numberThreads: 20	numberRequests: 500	time: 2468
diff --git a/docs/performance_archive/granular_tests/testViewStaticContentUnauthenticated_PERFORMANCE b/docs/performance_archive/granular_tests/testViewStaticContentUnauthenticated_PERFORMANCE
@@ -384,3 +384,4 @@
 2021-04-16	numberThreads: 10	numberRequests: 500	time: 229
 2021-04-17	numberThreads: 10	numberRequests: 500	time: 220
 2021-04-17	numberThreads: 10	numberRequests: 500	time: 242
+2021-04-21	numberThreads: 10	numberRequests: 500	time: 255
diff --git a/docs/performance_archive/granular_tests/testViewTime_PERFORMANCE b/docs/performance_archive/granular_tests/testViewTime_PERFORMANCE
@@ -385,3 +385,4 @@
 2021-04-16	numberThreads: 20	numberRequests: 100	time: 1055
 2021-04-17	numberThreads: 20	numberRequests: 100	time: 900
 2021-04-17	numberThreads: 20	numberRequests: 100	time: 876
+2021-04-21	numberThreads: 20	numberRequests: 100	time: 910