initial push #1
initial push #1
Conversation
.idea/.gitignore
Outdated
| @@ -0,0 +1,3 @@ | |||
| # Default ignored files | |||
There was a problem hiding this comment.
Please add all .idea files in gitignore
venv/CalculationClass.py
Outdated
| @@ -0,0 +1,50 @@ | |||
| import pandas as pd | |||
There was a problem hiding this comment.
Use 'snake_case` for file names. Do note that mistakes will be pointed out only once. You will be assessed on how well you can incorporate suggestions into your projects.
venv/CalculationClass.py
Outdated
|
|
||
|
|
||
| #Query Analysis Calculation Class | ||
| class Calculations(): |
There was a problem hiding this comment.
class Calculations:Remove Brackets.
Remove comment. Give class a more expressive name so you don't need the comment.
venv/CalculationClass.py
Outdated
| #Query Analysis Calculation Class | ||
| class Calculations(): | ||
|
|
||
| def __init__(self, dataframe,query): |
There was a problem hiding this comment.
def __init__(self, dataframe, query):Formatting (spacing) issues.
Use a formatter like black to handle formatting rather than doing it manually.
venv/CalculationClass.py
Outdated
|
|
||
| def perform_calculations_yearly(self): | ||
|
|
||
| if self.query=="high_temp": |
There was a problem hiding this comment.
Extra tabs. Formatting issue again.
There was a problem hiding this comment.
Read PEP-8 for python style guide. Read it thoroughly. I won't be pointing out mistakes related to PEP-8 from now on.
venv/CalculationClass.py
Outdated
| def perform_calculations_yearly(self): | ||
|
|
||
| if self.query=="high_temp": | ||
| self.result=print("\nI read high tempereature query\n") |
There was a problem hiding this comment.
Why are we printing this stuff? Is it part of the required output?
venv/PlottingClass.py
Outdated
|
|
||
| def perform_plotting(self): | ||
| if self.charttype == "normal": | ||
| self.dataframe["PKT"] = pd.to_datetime(self.dataframe["PKT"]) |
There was a problem hiding this comment.
Ahmad what's matplotlib doing here?
There was a problem hiding this comment.
Its plotting graphs for the report
venv/PlottingClass.py
Outdated
| @@ -0,0 +1,36 @@ | |||
| import pandas as pd | |||
There was a problem hiding this comment.
Store all your 3rd party libraries in requirements.txt
venv/Project1.py
Outdated
| @@ -0,0 +1,53 @@ | |||
| from ParsingClass import Parsing | |||
There was a problem hiding this comment.
What does Project1mean? What does it tell us about this project?
main.py
Outdated
| # Press the green button in the gutter to run the script. | ||
| if __name__ == '__main__': | ||
| print_hi('PyCharm') | ||
| print("This is my first pycharm program") |
There was a problem hiding this comment.
How do your run your project? Shouldn't the stuff in Project1 be called in here?
|
Also why are your project files in |
Pull request