Skip to content

Commit

Permalink
Merge pull request protocolbuffers#384 from haberman/internal
Browse files Browse the repository at this point in the history
Renamed .int.h to _internal.h, for greater clarity.
  • Loading branch information
haberman authored Apr 5, 2021
2 parents 5084cbe + 3881393 commit 75d6dab
Show file tree
Hide file tree
Showing 18 changed files with 33 additions and 33 deletions.
16 changes: 8 additions & 8 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,14 @@ cc_library(
name = "upb",
srcs = [
"upb/decode.c",
"upb/decode.int.h",
"upb/decode_internal.h",
"upb/encode.c",
"upb/msg.c",
"upb/msg.int.h",
"upb/msg_internal.h",
"upb/table.c",
"upb/table.int.h",
"upb/table_internal.h",
"upb/upb.c",
"upb/upb.int.h",
"upb/upb_internal.h",
],
hdrs = [
"upb/decode.h",
Expand All @@ -109,12 +109,12 @@ cc_library(
cc_library(
name = "fastdecode",
srcs = [
"upb/decode.int.h",
"upb/decode_internal.h",
"upb/decode_fast.c",
"upb/decode_fast.h",
"upb/msg.h",
"upb/msg.int.h",
"upb/upb.int.h",
"upb/msg_internal.h",
"upb/upb_internal.h",
],
copts = UPB_DEFAULT_COPTS,
deps = [
Expand Down Expand Up @@ -221,7 +221,7 @@ cc_library(
cc_library(
name = "table",
hdrs = [
"upb/table.int.h",
"upb/table_internal.h",
"upb/upb.h",
],
visibility = ["//tests:__pkg__"],
Expand Down
14 changes: 7 additions & 7 deletions cmake/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,14 @@ enable_testing()
add_library(port INTERFACE)
add_library(upb
../upb/decode.c
../upb/decode.int.h
../upb/decode_internal.h
../upb/encode.c
../upb/msg.c
../upb/msg.int.h
../upb/msg_internal.h
../upb/table.c
../upb/table.int.h
../upb/table_internal.h
../upb/upb.c
../upb/upb.int.h
../upb/upb_internal.h
../upb/decode.h
../upb/encode.h
../upb/msg.h
Expand All @@ -82,12 +82,12 @@ target_link_libraries(upb
port
/third_party/wyhash)
add_library(fastdecode
../upb/decode.int.h
../upb/decode_internal.h
../upb/decode_fast.c
../upb/decode_fast.h
../upb/msg.h
../upb/msg.int.h
../upb/upb.int.h)
../upb/msg_internal.h
../upb/upb_internal.h)
target_link_libraries(fastdecode
port
table)
Expand Down
2 changes: 1 addition & 1 deletion cmake/google/protobuf/descriptor.upb.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* regenerated. */

#include <stddef.h>
#include "upb/msg.int.h"
#include "upb/msg_internal.h"
#include "google/protobuf/descriptor.upb.h"

#include "upb/port_def.inc"
Expand Down
2 changes: 1 addition & 1 deletion cmake/google/protobuf/descriptor.upb.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#ifndef GOOGLE_PROTOBUF_DESCRIPTOR_PROTO_UPB_H_
#define GOOGLE_PROTOBUF_DESCRIPTOR_PROTO_UPB_H_

#include "upb/msg.int.h"
#include "upb/msg_internal.h"
#include "upb/decode.h"
#include "upb/decode_fast.h"
#include "upb/encode.h"
Expand Down
2 changes: 1 addition & 1 deletion tests/test_table.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

#include "tests/upb_test.h"
#include "upb/upb.hpp"
#include "upb/table.int.h"
#include "upb/table_internal.h"

#include "upb/port_def.inc"

Expand Down
4 changes: 2 additions & 2 deletions upb/decode.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@
#include <setjmp.h>
#include <string.h>

#include "upb/decode.int.h"
#include "upb/decode_internal.h"
#include "upb/upb.h"
#include "upb/upb.int.h"
#include "upb/upb_internal.h"

/* Must be last. */
#include "upb/port_def.inc"
Expand Down
2 changes: 1 addition & 1 deletion upb/decode_fast.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

#include "upb/decode_fast.h"

#include "upb/decode.int.h"
#include "upb/decode_internal.h"

/* Must be last. */
#include "upb/port_def.inc"
Expand Down
4 changes: 2 additions & 2 deletions upb/decode.int.h → upb/decode_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@

#include <setjmp.h>

#include "upb/msg.int.h"
#include "upb/upb.int.h"
#include "upb/msg_internal.h"
#include "upb/upb_internal.h"

/* Must be last. */
#include "upb/port_def.inc"
Expand Down
2 changes: 1 addition & 1 deletion upb/def.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
#define UPB_DEF_H_

#include "upb/upb.h"
#include "upb/table.int.h"
#include "upb/table_internal.h"
#include "google/protobuf/descriptor.upb.h"

/* Must be last. */
Expand Down
2 changes: 1 addition & 1 deletion upb/encode.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
#include <setjmp.h>
#include <string.h>

#include "upb/msg.int.h"
#include "upb/msg_internal.h"
#include "upb/upb.h"

/* Must be last. */
Expand Down
4 changes: 2 additions & 2 deletions upb/msg.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@

#include "upb/msg.h"

#include "upb/msg.int.h"
#include "upb/msg_internal.h"
#include "upb/port_def.inc"
#include "upb/table.int.h"
#include "upb/table_internal.h"

/** upb_msg *******************************************************************/

Expand Down
2 changes: 1 addition & 1 deletion upb/msg.int.h → upb/msg_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include <string.h>

#include "upb/msg.h"
#include "upb/table.int.h"
#include "upb/table_internal.h"
#include "upb/upb.h"

/* Must be last. */
Expand Down
2 changes: 1 addition & 1 deletion upb/reflection.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#include "upb/reflection.h"

#include <string.h>
#include "upb/table.int.h"
#include "upb/table_internal.h"
#include "upb/msg.h"

#include "upb/port_def.inc"
Expand Down
2 changes: 1 addition & 1 deletion upb/table.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
#include <string.h>

#include "third_party/wyhash/wyhash.h"
#include "upb/table.int.h"
#include "upb/table_internal.h"

/* Must be last. */
#include "upb/port_def.inc"
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion upb/upb.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

#include "upb/upb.int.h"
#include "upb/upb_internal.h"

#include <errno.h>
#include <stdarg.h>
Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions upbc/protoc-gen-upb.cc
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ void WriteHeader(const protobuf::FileDescriptor* file, Output& output) {
output(
"#ifndef $0_UPB_H_\n"
"#define $0_UPB_H_\n\n"
"#include \"upb/msg.int.h\"\n"
"#include \"upb/msg_internal.h\"\n"
"#include \"upb/decode.h\"\n"
"#include \"upb/decode_fast.h\"\n"
"#include \"upb/encode.h\"\n\n",
Expand Down Expand Up @@ -849,7 +849,7 @@ void WriteSource(const protobuf::FileDescriptor* file, Output& output,

output(
"#include <stddef.h>\n"
"#include \"upb/msg.int.h\"\n"
"#include \"upb/msg_internal.h\"\n"
"#include \"$0\"\n",
HeaderFilename(file->name()));

Expand Down

0 comments on commit 75d6dab

Please sign in to comment.