define issue templates for each Issue Type #10914
Open
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
5cea150
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a01fe17.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-issue-type-templates.agoric-sdk.pages.dev |
mhofman
reviewed
Jan 29, 2025
There was a problem hiding this comment.
I think we need to give some guidelines as to what constitutes a task. The worry is that we'd end up with standalone tasks (not sub-tasks) that end up having significant impact on chain behavior, or non-trivial upgrade considerations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
GitHub has been improving their Issues functionality. They now have Issue Types.
This adopts them in our templates. Our
work_itemtemplate conflated Features and Tasks so this splits them into two templates. The existing structure seemed best suited for "feature" so this adds a new simpler structure for "task".Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
Somewhat self-documenting. Once approved by eng leads we'll need to communicate with the team before enacting (by merge).
Testing Considerations
Would be nice if we could see it in action but not possible until merge. Easy to tweak though.
Upgrade Considerations
n/a
(I wonder if we should have another PR template for stuff like this that obviously has no upgrade impact.)