Merge pull request Hubs-Foundation#4824 from mozilla/fix-twitter-popu…

…p-issue Popup window closes itself on oauth-success
AlbionaHoti · Nov 9, 2021 · a53a60b · a53a60b
2 parents 3f2893a + 4de8404
commit a53a60b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/src/hub.js b/src/hub.js
@@ -267,6 +267,7 @@ let isOAuthModal = false;
 if (window.opener && window.opener.doingTwitterOAuth) {
   window.opener.postMessage("oauth-successful");
   isOAuthModal = true;
+  window.close();
 }
 
 const isBotMode = qsTruthy("bot");

diff --git a/src/react-components/room/TwitterOAuthModalContainer.js b/src/react-components/room/TwitterOAuthModalContainer.js
@@ -41,7 +41,6 @@ export function TwitterOAuthModalContainer({ hubChannel, onConnected, onClose })
       function onMessage({ data }) {
         if (data === "oauth-successful") {
           onConnected();
-          popupRef.current.close();
           popupRef.current = null;
           delete window.doingTwitterOAuth;
           window.removeEventListener("message", onMessage);