Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

Commit

Permalink
Migrated 1.0.x bug fix for #9 and updated different dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexanderEggers committed Aug 14, 2020
1 parent 1129dd9 commit 8bf227a
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 18 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ repositories {
}
dependencies {
implementation 'org.hitogo:hitogo-core:1.0.2'
testImplementation 'org.hitogo:hitogo-testing:1.0.2' //mocks and testing tools
implementation 'org.hitogo:hitogo-core:1.0.3'
testImplementation 'org.hitogo:hitogo-testing:1.0.3' //mocks and testing tools
}
```

How do I use Hitogo? (Step-by-step introduction for 1.0.2)
How do I use Hitogo? (Step-by-step introduction for 1.0.3)
-------------------

1. Extend the HitogoController
Expand Down Expand Up @@ -162,9 +162,9 @@ If you have finished step 1 and 2, you are ready to go! Using Hitogo you can cre

Status
------
Version 1.1.0 is currently under development in the develop branch. The latest stable version is 1.0.2 which can be found in the 1.0.x branch.
Version 1.1.0 is currently under development in the develop branch. The latest stable version is 1.0.3 which can be found in the 1.0.x branch.

Each new version version will be supported until the next version is released. For example: 1.0.1 is supported until 1.1.0 or 1.0.2 is out. Each minor release won't include any public API changes.
Each new version version will be supported until the next version is released. For example: 1.0.3 is supported until 1.1.0 or 1.0.4 is out. Each minor release won't include any public API changes.

Comments/bugs/questions/pull requests are always welcome!

Expand Down
10 changes: 5 additions & 5 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
buildscript {

ext {
support_default_lib_version = '1.0.0'
support_appcompat_version = "1.1.0"
support_material_version = "1.2.0"
support_appcompat_version = "1.2.0"
support_annotation_version = "1.1.0"

juni_version = "4.12"
juni_version = "4.13"
mockito_version = "1.10.19"

hitogo_library_version = "1.1.0"
Expand All @@ -19,8 +19,8 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:3.5.2'
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4'
classpath 'com.android.tools.build:gradle:4.0.1'
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.5'
classpath 'com.github.dcendents:android-maven-gradle-plugin:2.1'
}
}
Expand Down
4 changes: 1 addition & 3 deletions core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ android {

dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])

//Support lib dependencies
implementation "com.google.android.material:material:$support_default_lib_version"
implementation "com.google.android.material:material:$support_material_version"
}

if (project.rootProject.file('local.properties').exists()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ protected void buildLayoutContent(View view, @NonNull AlertDialog.Builder builde
Drawable drawable = drawableMap.valueAt(i);
setDrawable(view, viewId, drawable);
}
} else if (textMap.size() > 0) {
} else if (drawableMap.size() > 0) {
builder.setIcon(drawableMap.valueAt(0));
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ protected void onCreate(@NonNull HitogoController controller, @NonNull ViewAlert
"Use for example the LinearLayout to solve this issue.");
}

if (containerView != null && containerView instanceof ViewGroup) {
if (containerView instanceof ViewGroup) {
viewGroup = (ViewGroup) containerView;
} else {
Log.e(ViewAlertBuilderImpl.class.getName(), "Cannot find any container view. " +
Expand Down
3 changes: 1 addition & 2 deletions examples/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ dependencies {
implementation project(path: ':hitogo-core')
implementation project(path: ':hitogo-support')

//Support lib dependencies
implementation "androidx.appcompat:appcompat:$support_appcompat_version"
implementation "com.google.android.material:material:$support_default_lib_version"
implementation "com.google.android.material:material:$support_material_version"
}
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.1.1-all.zip

0 comments on commit 8bf227a

Please sign in to comment.