Skip to content

Commit

Permalink
Remove group role for link in treeview (#41277)
Browse files Browse the repository at this point in the history
  • Loading branch information
gracepark authored Aug 23, 2023
1 parent 0b03061 commit be25914
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion components/sidebar/ProductCollapsibleSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ export const ProductCollapsibleSection = (props: SectionProps) => {
}}
>
<Link
role="group"
id={page.href}
href={page.href}
className={cx('color-fg-default no-underline', isCurrent ? 'text-bold' : '')}
Expand Down
2 changes: 1 addition & 1 deletion tests/rendering-fixtures/playwright-rendering.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ test('use sidebar to go to Hello World page', async ({ page }) => {
await expect(page).toHaveTitle(/Getting started with HubGit/)

await page.getByTestId('product-sidebar').getByText('Quickstart').click()
await page.getByTestId('product-sidebar').getByRole('group', { name: 'Hello World' }).click()
await page.getByTestId('product-sidebar').getByText('Hello World').click()
await expect(page).toHaveURL(/\/en\/get-started\/quickstart\/hello-world/)
await expect(page).toHaveTitle(/Hello World - GitHub Docs/)
})
Expand Down

0 comments on commit be25914

Please sign in to comment.