Close channels when dune disconnects

Signed-off-by: Rudi Grinberg <[email protected]>
Alizter · Jun 29, 2021 · ebc0905 · ebc0905
1 parent c88be05
commit ebc0905
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/ocaml-lsp-server/src/dune.ml b/ocaml-lsp-server/src/dune.ml
@@ -92,7 +92,8 @@ end = struct
     let+ (_ : Unix.process_status) = Scheduler.wait_for_process t.pid in
     Scheduler.stop t.in_thread;
     Scheduler.stop t.out_thread;
-    ()
+    close_out_noerr t.out_chan;
+    close_in_noerr t.in_chan
 end
 
 module Client =

diff --git a/ocaml-lsp-server/src/progress.ml b/ocaml-lsp-server/src/progress.ml
@@ -1,8 +1,8 @@
 open Import
 
 type enabled =
-  (* TODO this needs to be mutexed *)
-  { mutable token : ProgressToken.t option
+  { (* TODO this needs to be mutexed *)
+    mutable token : ProgressToken.t option
   ; mutable build_counter : int
   ; report_progress :
       Server_notification.Progress.t ProgressParams.t -> unit Fiber.t