Skip to content

Commit

Permalink
KAFKA-2831; Do not use ZKUtils in ConsumerGroupCommand if `new-cons…
Browse files Browse the repository at this point in the history
…umer` is used

Author: Ismael Juma <[email protected]>

Reviewers: Jason Gustafson <[email protected]>, Ashish Singh <[email protected]>, Jun Rao <[email protected]>

Closes apache#528 from ijuma/kafka-2831-consumer-group-command-zookeeper-new-consumer
  • Loading branch information
ijuma authored and junrao committed Nov 16, 2015
1 parent 4a3d244 commit 5fc4546
Show file tree
Hide file tree
Showing 2 changed files with 310 additions and 248 deletions.
16 changes: 10 additions & 6 deletions core/src/main/scala/kafka/admin/AdminClient.scala
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,10 @@ class AdminClient(val time: Time,
GroupSummary(metadata.state(), metadata.protocolType(), metadata.protocol(), members)
}

case class ConsumerSummary(
memberId: String,
clientId: String,
clientHost: String,
assignment: List[TopicPartition])
case class ConsumerSummary(memberId: String,
clientId: String,
clientHost: String,
assignment: List[TopicPartition])

def describeConsumerGroup(groupId: String): List[ConsumerSummary] = {
val group = describeGroup(groupId)
Expand All @@ -169,6 +168,11 @@ class AdminClient(val time: Time,
List.empty
}
}

def close() {
client.close()
}

}

object AdminClient {
Expand Down Expand Up @@ -249,4 +253,4 @@ object AdminClient {
highLevelClient,
bootstrapCluster.nodes().asScala.toList)
}
}
}
Loading

0 comments on commit 5fc4546

Please sign in to comment.