Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDL 1.2 dev libs #2

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Add SDL 1.2 dev libs #2

merged 1 commit into from
Oct 14, 2019

Conversation

apiraino
Copy link
Member

These are not strictly required but a nice to have when building AROS.

Would it make sense to add this to the general base image?

@MBeijer
Copy link
Member

MBeijer commented Oct 14, 2019

It makes sense when building AROS in general, and since we're building AROS in our Jenkins server with this base image, I say why not. But perhaps we should have two base images. One for building AROS + the other toolchains, and one base for all docker images. We don't really need regular gcc in the environment where the crosstools are.

I'd like to keep the environments slim so they're quick to download and get started with. What do you say? :)

@MBeijer MBeijer merged commit 15cf8ac into master Oct 14, 2019
@apiraino
Copy link
Member Author

apiraino commented Oct 14, 2019

I agree, let's keep base images as lean and slim as possible.

When I've figured out the complete Docker roundtrip for AROS, we can optimize here and there (f.e. I'd like to test Alpine for Docker base images).

@MBeijer
Copy link
Member

MBeijer commented Oct 14, 2019 via email

@apiraino apiraino deleted the add-sdl-libs branch October 19, 2019 13:59
@apiraino
Copy link
Member Author

I've thought a bit about this. I'm not sure how can we "export" or "copy" a compiled crosstoolchain into another docker recipe file without breaking it.

if we want to slim down the images size we can start with:

  • testing another base image (like Alpine or else) in this repo
  • remove the whole gcc toolchains and all unneeded stuff from the final images once the building image is done.

Thoughts on this?

@MBeijer
Copy link
Member

MBeijer commented Oct 19, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants