[Refactoring] improve the data of view_tables function Unit test

AmrMohamad · Dec 12, 2022 · 46abf30 · 46abf30
1 parent 0f09dbc
commit 46abf30
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 1 deletion.
diff --git a/__pycache__/pykanban.cpython-310.pyc b/__pycache__/pykanban.cpython-310.pyc
diff --git a/__pycache__/test_pykanban.cpython-310-pytest-7.1.3.pyc b/__pycache__/test_pykanban.cpython-310-pytest-7.1.3.pyc
diff --git a/__pycache__/test_pykanban.cpython-310-pytest-7.2.0.pyc b/__pycache__/test_pykanban.cpython-310-pytest-7.2.0.pyc
diff --git a/pykanban.py b/pykanban.py
@@ -226,7 +226,8 @@ def init_table(table_name: str) -> str:
 
 def view_tables() -> list[str]:
     dir_path = f"{DATA_DIR}"
-    if len(os.listdir(dir_path)) == 0 or '.DS_Store' in os.listdir(dir_path):
+    c = os.listdir(dir_path)
+    if os.listdir(dir_path) == ['.DS_Store'] or len(os.listdir(dir_path)) == 0:
         return f"No Tables Exist"
     tables_list = []
     for path in os.scandir(dir_path):

diff --git a/test_pykanban.py b/test_pykanban.py
@@ -284,6 +284,9 @@ def test_init_table():
 
 def test_view_tables():
     destination = "./test_data"
+    os.mkdir("./data/_temp/")
+    temp = open("./data/_temp/latest.csv","w")
+    temp.close()
     os.mkdir(destination)
     # shutil.rmtree(f'{destination}/.DS_Store')
     for f in os.listdir("./data"):
@@ -298,6 +301,7 @@ def test_view_tables():
         name_tables.append(nt)
     assert view_tables() == name_tables
     os.rmdir(destination)
+    shutil.rmtree("./data/_temp/")
     ...