Skip to content

Commit

Permalink
Make GenericUrl's #equals pass static analysis (googleapis#440)
Browse files Browse the repository at this point in the history
We'll start matching this with a new error-prone (https://github.com/google/error-prone) check soon otherwise: it looks like this is comparing two different getters.
  • Loading branch information
graememorgan authored and chingor13 committed Aug 2, 2018
1 parent a71b8ac commit dfcc004
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ public boolean equals(Object obj) {
}
GenericUrl other = (GenericUrl) obj;
// TODO(yanivi): optimize?
return build().equals(other.toString());
return build().equals(other.build());
}

@Override
Expand Down

0 comments on commit dfcc004

Please sign in to comment.