fixed typo in password and text field validations (keystonejs#7119)

* was showing "must be no longer than x.min" not x.max for longer inputs
Antonwy · Dec 25, 2021 · 23351e4 · 23351e4
1 parent f63210a
commit 23351e4
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/keystone/src/fields/types/password/index.ts b/packages/keystone/src/fields/types/password/index.ts
@@ -138,7 +138,7 @@ export const password =
             }
             if (validation.length.max !== null && val.length > validation.length.max) {
               args.addValidationError(
-                `${fieldLabel} must be no longer than ${validation.length.min} characters`
+                `${fieldLabel} must be no longer than ${validation.length.max} characters`
               );
             }
             if (validation.match && !validation.match.regex.test(val)) {

diff --git a/packages/keystone/src/fields/types/password/views/index.tsx b/packages/keystone/src/fields/types/password/views/index.tsx
@@ -40,7 +40,7 @@ function validate(value: Value, validation: Validation, fieldLabel: string): str
       return `${fieldLabel} must be at least ${validation.length.min} characters long`;
     }
     if (validation.length.max !== null && val.length > validation.length.max) {
-      return `${fieldLabel} must be no longer than ${validation.length.min} characters`;
+      return `${fieldLabel} must be no longer than ${validation.length.max} characters`;
     }
     if (validation.match && !validation.match.regex.test(val)) {
       return validation.match.explanation;

diff --git a/packages/keystone/src/fields/types/text/index.ts b/packages/keystone/src/fields/types/text/index.ts
@@ -111,7 +111,7 @@ export const text =
             }
             if (validation?.length?.max !== undefined && val.length > validation.length.max) {
               args.addValidationError(
-                `${fieldLabel} must be no longer than ${validation.length.min} characters`
+                `${fieldLabel} must be no longer than ${validation.length.max} characters`
               );
             }
             if (validation?.match && !validation.match.regex.test(val)) {

diff --git a/packages/keystone/src/fields/types/text/views/index.tsx b/packages/keystone/src/fields/types/text/views/index.tsx
@@ -155,7 +155,7 @@ function validate(value: TextValue, validation: Validation, fieldLabel: string):
     }
   }
   if (validation.length.max !== null && val.length > validation.length.max) {
-    messages.push(`${fieldLabel} must be no longer than ${validation.length.min} characters`);
+    messages.push(`${fieldLabel} must be no longer than ${validation.length.max} characters`);
   }
   if (validation.match && !validation.match.regex.test(val)) {
     messages.push(