-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
22 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b529043
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello,i saw all your commits, so i will expalin problem exactly,i dont use your sidekit because give me an error in the begining ,this is a part from code to determine the problem:
@Anwarvic
when i run it ,give me this error
b529043
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when i run code using sidekit from pip in Jupyter notbook
and this is the code :
cell num=1
cell num=2
cell num=3
cell num=4
the code is run until cell num=4,it give error which is:
b529043
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First Issue
First, let's start with the first issue... May I ask you for a favor?? Go to the repo of this project on Github and open the file
extract_features.py
. You will see that I specifically pointed out to useextractor.save
instead ofextractor.save_list
as the latter is prone to error as "it is buggy and freezes after some time. I don't recommend using it". So, I suggest usingsave()
instead ofsave_list()
which can be done like so:Instead of:
Why is that the case?
I'm not sure, it might be the order of the files
Second Issue
According to the second issue, I can see that you have used:
Which I don't recommend at all, I think the
feature_size
anddistrib_nb
should be taken from the UBM model. So, I suggest using:Little Note
Commenting on commits isn't the best way to solve code problems for multiple reasons:
Read
to get here. If there are no new comments, I won't be able to access them back unless I remember which commit did you comment on.So, I suggest writing all the problems that you have in the
issues
panel. And check this link for reference.I know the code is messy and I have made a lot of changes in a small period of time. So, thanks for sticking with me during this period :)