fix: added missing env parameter for ADMIN_FRONTEND_APPFLOWY_CLOUD_URL to deploy.env #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can (and certainly should) add this variable. Although, if gotrue service and appflowy cloud service are deployed on the same network/docker compose, gotrue service can reach appflowy cloud directly via the service name |
|
Anyway, this PR looks good to me. Once the commit message has been amended, we can merge this. The commit message should be in the form of (fix: [description starting with lower case]) |
khorshuheng
approved these changes
Jan 2, 2025
nicolaus-hee
changed the title
Adding ADMIN_FRONTEND_APPFLOWY_CLOUD_URL to `deploy.env` for convenience and consistency
khorshuheng
added a commit
that referenced
this pull request
Jan 2, 2025
fix: added missing env parameter for ADMIN_FRONTEND_APPFLOWY_CLOUD_URL to deploy.env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-compose.ymlhas env variableADMIN_FRONTEND_APPFLOWY_CLOUD_URLset to${ADMIN_FRONTEND_APPFLOWY_CLOUD_URL:-http://appflowy_cloud:8000}, thoughdeploy.envmakes no mention of the variable. In my environment, I needed to change the hostname which would also require changing it indeploy.envwhere it is not mentioned. I suggest adding it with the default value for convenience and consistency (the other twoADMIN_FRONTEND_...are included) purposes.