Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix description line endings in typescript enums #703

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

calebstott
Copy link

"\t{} = {}, // {}\n".format(entry.name, entry.value, entry.description.rstrip("\r").rstrip("\n")))

If a xml schema contains a multiline description on windows, the CRLF remains in the generated code leaving a syntax error
I believe this is due to the order of the rstrip operations
Think it would be better to replace with a space, so then comments will still have some sort of separator

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant