Remove Python 2 and Python 3.5 supporting code #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotu
changed the title
alehed
reviewed
Jun 27, 2023
| @@ -104,7 +97,6 @@ def run(self): | |||
| 'Intended Audience :: Science/Research', | |||
| 'License :: OSI Approved :: GNU Lesser General Public License v3 (LGPLv3)', | |||
| 'Operating System :: OS Independent', | |||
| 'Programming Language :: Python :: 2.7', | |||
| 'Programming Language :: Python :: 3.6', | |||
There was a problem hiding this comment.
I would specify here that also 3.10 as well as 3.11 are supported. Otherwise pip will refuse to install it on these platforms.
There was a problem hiding this comment.
I absolutely should add 3.10 and 3.11 and I'll push that in a different PR.
I tried to install the published version of pymavlink on python 3.11.3 with pip 23.1.2 and it worked fine despite the classifiers, so I think these are informational only.
Thanks for the comment! In looking it up, I learned about the setup(python_requires=...) argument which does enforce versions via pip https://python3statement.org/practicalities/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanup in furtherance of #556