Fix: typo in deploy.py

Typo error in xml mimetype deploy to S3 storage. Thais patch remove the extra sign to correctly map mimetype to content-type. Signed-off-by: pmikus <[email protected]> Change-Id: Ia88ac75f483b31312ae72cc104021ab9efda6455
Aricg · Aug 23, 2021 · da1e676 · da1e676
1 parent d263044
commit da1e676
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lftools/deploy.py b/lftools/deploy.py
@@ -431,7 +431,7 @@ def _upload_to_s3(file):
         extra_args = {"ContentType": "text/plain"}
         text_html_extra_args = {"ContentType": "text/html", "ContentEncoding": mimetypes.guess_type(file)[1]}
         text_plain_extra_args = {"ContentType": "text/plain", "ContentEncoding": mimetypes.guess_type(file)[1]}
-        app_xml_extra_args = {"ContentType": "application/xml'", "ContentEncoding": mimetypes.guess_type(file)[1]}
+        app_xml_extra_args = {"ContentType": "application/xml", "ContentEncoding": mimetypes.guess_type(file)[1]}
         if file == "_tmpfile":
             for dir in (logs_dir, silo_dir, jenkins_node_dir):
                 try:

diff --git a/releasenotes/notes/fix-deploy-xml-c99387e7b5c4622e.yaml b/releasenotes/notes/fix-deploy-xml-c99387e7b5c4622e.yaml
@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    Typo error in xml mimetype deploy to S3 storage. Thais patch remove the
+    extra sign to correctly map mimetype to content-type.