Fix enemy update bug

Arkzzz · Mar 16, 2018 · 8c40596 · 8c40596
1 parent 382a679
commit 8c40596
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,6 +1,11 @@
 # Changelog
 This changelog uses [Semantic Versioning 2.0.0](https://semver.org/).
 
+## `6.17.1`
+### Fixes:
+ + Fixed a bug where enemies would not receive new tick updates sometimes.
+ + Fixed a typo in the `Projectile` class.
+
 ## `6.17.0`
 > The changes in this version are part of features which are not fully complete yet and may still contain bugs.
 > If you need a **stable** version of nrelay, do not upgrade to this version.

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nrelay",
-  "version": "6.17.0",
+  "version": "6.17.1",
   "description": "A console based modular client for Realm of the Mad God built with Node.js and TypeScript.",
   "main": "index.js",
   "bin": {

diff --git a/src/core/client.ts b/src/core/client.ts
@@ -452,7 +452,7 @@ export class Client {
                                         Log(this.alias, 'Preventing EnemyHit. Time since last update: ' + lastUpdate, LogLevel.Warning);
                                     }
                                     this.projectiles.splice(i, 1);
-                                    break;
+                                    continue;
                                 }
                                 const enemyHit = new EnemyHitPacket();
                                 const damage = closestEnemy.damage(this.projectiles[i].damage);
@@ -465,7 +465,7 @@ export class Client {
                                 if (enemyHit.kill) {
                                     closestEnemy.dead = true;
                                 }
-                                break;
+                                continue;
                             }
                         }
                     }
@@ -539,7 +539,9 @@ export class Client {
                     }
                 }
                 if (obj.enemy) {
-                    this.enemies[updatePacket.newObjects[i].status.objectId] = new Enemy(obj);
+                    if (!this.enemies[updatePacket.newObjects[i].status.objectId]) {
+                        this.enemies[updatePacket.newObjects[i].status.objectId] = new Enemy(obj);
+                    }
                     this.enemies[updatePacket.newObjects[i].status.objectId].update(updatePacket.newObjects[i].status);
                 }
             }
@@ -663,10 +665,10 @@ export class Client {
                 this.playerData.objectId = this.objectId;
                 this.playerData.worldPos = this.worldPos;
                 this.playerData.server = this.server.name;
-                break;
+                continue;
             }
-            if (this.enemies[newTickPacket.statuses[i].objectId]) {
-                this.enemies[newTickPacket.statuses[i].objectId].update(newTickPacket.statuses[i]);
+            if (this.enemies[status.objectId]) {
+                this.enemies[status.objectId].update(status);
             }
         }
 

diff --git a/src/models/projectile.ts b/src/models/projectile.ts
@@ -72,7 +72,7 @@ export class Projectile {
             const angleX = Math.cos(this.startAngle);
             const angleY = Math.sin(this.startAngle);
             point.x += (offset2 * angleY - offset3 * angleX) * this.projectileProperties.magnitude;
-            point.x += (offset2 * angleX - offset3 * angleY) * this.projectileProperties.magnitude;
+            point.y += (offset2 * angleX - offset3 * angleY) * this.projectileProperties.magnitude;
         } else {
             if (this.projectileProperties.boomerang) {
                 const halfwayPoint = this.projectileProperties.lifetimeMS * (this.projectileProperties.speed / 10000) / 2;