squid:S2325 private methods that don't access instance data should be…

… static
ArslanKathia · Feb 15, 2016 · b7ceb28 · b7ceb28
1 parent 3b22266
commit b7ceb28
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/muxer/src/main/java/org/mp4parser/muxer/builder/FragmentedMp4Builder.java b/muxer/src/main/java/org/mp4parser/muxer/builder/FragmentedMp4Builder.java
@@ -715,7 +715,7 @@ protected ParsableBox createTkhd(Movie movie, Track track) {
  return tkhd;
  }
 
- private long getTrackDuration(Movie movie, Track track) {
+ private static long getTrackDuration(Movie movie, Track track) {
  return (track.getDuration() * movie.getTimescale()) / track.getTrackMetaData().getTimescale();
  }
 

diff --git a/muxer/src/main/java/org/mp4parser/muxer/tracks/AC3TrackImpl.java b/muxer/src/main/java/org/mp4parser/muxer/tracks/AC3TrackImpl.java
@@ -453,7 +453,7 @@ private AudioSampleEntry createAudioSampleEntry() throws IOException {
  return audioSampleEntry;
  }
 
- private int getFrameSize(int code, int fscod) {
+ private static int getFrameSize(int code, int fscod) {
  int frmsizecode = code >>> 1;
  int flag = code & 1;
  if (frmsizecode > 18 || flag > 1 || fscod > 2) {

diff --git a/muxer/src/main/java/org/mp4parser/muxer/tracks/DTSTrackImpl.java b/muxer/src/main/java/org/mp4parser/muxer/tracks/DTSTrackImpl.java
@@ -673,7 +673,7 @@ public ByteBuffer asByteBuffer() {
  return mySamples;
  }
 
- private int getBitRate(int rate) throws IOException {
+ private static int getBitRate(int rate) throws IOException {
  int bitrate;
  switch (rate)
 
@@ -789,7 +789,7 @@ private int getBitRate(int rate) throws IOException {
  return bitrate;
  }
 
- private int getSampleRate(int sfreq) throws IOException {
+ private static int getSampleRate(int sfreq) throws IOException {
  int samplerate;
  switch (sfreq)
 

diff --git a/muxer/src/main/java/org/mp4parser/muxer/tracks/h264/parsing/model/SeqParameterSet.java b/muxer/src/main/java/org/mp4parser/muxer/tracks/h264/parsing/model/SeqParameterSet.java
@@ -504,7 +504,7 @@ private void writeVUIParameters(VUIParameters vuip, CAVLCWriter writer)
 
  }
 
- private void writeHRDParameters(HRDParameters hrd, CAVLCWriter writer)
+ private static void writeHRDParameters(HRDParameters hrd, CAVLCWriter writer)
  throws IOException {
  writer.writeUE(hrd.cpb_cnt_minus1, "HRD: cpb_cnt_minus1");
  writer.writeNBit(hrd.bit_rate_scale, 4, "HRD: bit_rate_scale");

diff --git a/muxer/src/main/java/org/mp4parser/muxer/tracks/h265/SequenceParameterSetRbsp.java b/muxer/src/main/java/org/mp4parser/muxer/tracks/h265/SequenceParameterSetRbsp.java
@@ -71,7 +71,7 @@ public SequenceParameterSetRbsp(InputStream is) throws IOException {
  }
  }
 
- private void scaling_list_data(CAVLCReader bsr) throws IOException {
+ private static void scaling_list_data(CAVLCReader bsr) throws IOException {
  boolean[][] scaling_list_pred_mode_flag = new boolean[4][];
  int[][] scaling_list_pred_matrix_id_delta = new int[4][];
  int[][] scaling_list_dc_coef_minus8 = new int[2][];
@@ -104,7 +104,7 @@ private void scaling_list_data(CAVLCReader bsr) throws IOException {
  }
 
 
- private void profile_tier_level(int maxNumSubLayersMinus1, CAVLCReader bsr) throws IOException {
+ private static void profile_tier_level(int maxNumSubLayersMinus1, CAVLCReader bsr) throws IOException {
  int general_profile_space = bsr.readU(2, "general_profile_space");
  boolean general_tier_flag = bsr.readBool("general_tier_flag");
  int general_profile_idc = bsr.readU(5, "general_profile_idc");