Tests: Fix tests (safe-global#3960)

* Fix tests
Arya-A-Nair · Jul 17, 2024 · 6bc0ef7 · 6bc0ef7
1 parent e66e95f
commit 6bc0ef7
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/cypress/e2e/pages/swaps.pages.js b/cypress/e2e/pages/swaps.pages.js
@@ -178,11 +178,10 @@ function selectCurrency(inputSelector, option) {
   cy.get(inputSelector).within(() => {
     cy.get('button')
       .eq(0)
-      .find('span')
       .invoke('text')
       .then(($value) => {
         cy.log('*** Currency value ' + $value)
-        if ($value != option) {
+        if (!$value.includes(option)) {
           cy.log('*** Currency value is different from specified')
           cy.get('button').eq(0).trigger('mouseover').trigger('click')
           cy.wrap(true).as('isAction')

diff --git a/cypress/e2e/regression/create_safe_simple.cy.js b/cypress/e2e/regression/create_safe_simple.cy.js
@@ -134,7 +134,6 @@ describe('Safe creation tests', () => {
         main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addressBook, ls.addressBookData.sameOwnerName),
       )
       .then(() => {
-        wallet.connectSigner(signer)
         createwallet.clickOnContinueWithWalletBtn()
         createwallet.clickOnCreateNewSafeBtn()
         createwallet.clickOnNextBtn()

diff --git a/cypress/e2e/regression/nfts.cy.js b/cypress/e2e/regression/nfts.cy.js
@@ -87,7 +87,6 @@ describe('NFTs tests', () => {
 
   it('Verify Send NFT transaction has been created', () => {
     cy.visit(constants.balanceNftsUrl + nftsSafes.SEP_NFT_SAFE_1)
-    wallet.connectSigner(signer)
     nfts.verifyInitialNFTData()
     nfts.selectNFTs(1)
     nfts.sendNFT()

diff --git a/cypress/e2e/regression/swaps.cy.js b/cypress/e2e/regression/swaps.cy.js
@@ -45,7 +45,7 @@ describe('Swaps tests', () => {
       swaps.setInputValue(4)
       swaps.selectOutputCurrency(swaps.swapTokens.dai)
       swaps.checkSwapBtnIsVisible()
-      swaps.isInputGreaterZero(swaps.outputurrencyInput).then((isGreaterThanZero) => {
+      swaps.isInputGreaterZero(swaps.outputCurrencyInput).then((isGreaterThanZero) => {
         cy.wrap(isGreaterThanZero).should('be.true')
       })
       swaps.clickOnExceeFeeChkbox()
@@ -142,8 +142,9 @@ describe('Swaps tests', () => {
       swaps.setExpiry('2')
       swaps.clickOnSettingsBtn()
       swaps.setInputValue(4)
+      swaps.selectOutputCurrency(swaps.swapTokens.dai)
       swaps.checkSwapBtnIsVisible()
-      swaps.isInputGreaterZero(swaps.outputurrencyInput).then((isGreaterThanZero) => {
+      swaps.isInputGreaterZero(swaps.outputCurrencyInput).then((isGreaterThanZero) => {
         cy.wrap(isGreaterThanZero).should('be.true')
       })
       swaps.clickOnExceeFeeChkbox()
@@ -173,6 +174,7 @@ describe('Swaps tests', () => {
         cy.wrap($frame).within(() => {
           swaps.selectInputCurrency(swaps.swapTokens.cow)
           swaps.setInputValue(4)
+          swaps.selectOutputCurrency(swaps.swapTokens.dai)
           swaps.checkSwapBtnIsVisible()
           swaps.clickOnSettingsBtn()