Skip to content

Commit

Permalink
Remove obsolete CustomDefaultVideoPoster histogram.
Browse files Browse the repository at this point in the history
Remove the Android.WebView.CustomDefaultVideoPoster histogram. About
10-20% of calls return a poster, so will need some consideration of how
to proceed.

Fixed: 1224669
Bug: 1189632
Change-Id: I9e2e81061a25ab3169866835f58c1d6257cf0d9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3064939
Auto-Submit: Richard Coles <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Weilun Shi <[email protected]>
Commit-Queue: Weilun Shi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#907636}
  • Loading branch information
tornewuff authored and Chromium LUCI CQ committed Aug 2, 2021
1 parent e1ec608 commit 13b3f86
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
import org.chromium.base.ContextUtils;
import org.chromium.base.Log;
import org.chromium.base.TraceEvent;
import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.metrics.ScopedSysTraceEvent;
import org.chromium.base.task.PostTask;
import org.chromium.components.embedder_support.util.WebResourceResponseInfo;
Expand Down Expand Up @@ -1006,8 +1005,6 @@ public Bitmap getDefaultVideoPoster() {
if (TRACE) Log.i(TAG, "getDefaultVideoPoster");
result = mWebChromeClient.getDefaultVideoPoster();
}
RecordHistogram.recordBooleanHistogram(
"Android.WebView.CustomDefaultVideoPoster", result != null);
if (result == null) {
// The ic_play_circle_outline_black_48dp icon is transparent so we need to draw it
// on a gray background.
Expand Down
3 changes: 3 additions & 0 deletions tools/metrics/histograms/metadata/android/histograms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3160,6 +3160,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.

<histogram name="Android.WebView.CustomDefaultVideoPoster" enum="Boolean"
expires_after="2021-08-01">
<obsolete>
Removed Aug 2021.
</obsolete>
<owner>[email protected]</owner>
<owner>src/android_webview/OWNERS</owner>
<summary>
Expand Down

0 comments on commit 13b3f86

Please sign in to comment.