Skip to content

Commit

Permalink
Move PDF thumbnails files to //pdf/ui/
Browse files Browse the repository at this point in the history
These files mostly contain utilities for supporting the PDF Viewer's
thumbnail bar, thus qualifying them for inclusion in the new directory.

Bug: 1184342
Change-Id: Ifcb36dc9e27c0fc24c0abdac4e2d19d780e0d7fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2753341
Auto-Submit: Daniel Hosseinian <[email protected]>
Commit-Queue: Daniel Hosseinian <[email protected]>
Commit-Queue: K. Moon <[email protected]>
Reviewed-by: K. Moon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#862222}
  • Loading branch information
Daniel Hosseinian authored and Chromium LUCI CQ committed Mar 12, 2021
1 parent b7b3b0d commit ccff942
Show file tree
Hide file tree
Showing 9 changed files with 14 additions and 14 deletions.
6 changes: 3 additions & 3 deletions pdf/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,12 @@ if (enable_pdf) {
"preview_mode_client.h",
"range_set.cc",
"range_set.h",
"thumbnail.cc",
"thumbnail.h",
"ui/file_name.cc",
"ui/file_name.h",
"ui/format_page_size.cc",
"ui/format_page_size.h",
"ui/thumbnail.cc",
"ui/thumbnail.h",
"url_loader_wrapper.h",
"url_loader_wrapper_impl.cc",
"url_loader_wrapper_impl.h",
Expand Down Expand Up @@ -364,9 +364,9 @@ if (enable_pdf) {
"ppapi_migration/url_loader_unittest.cc",
"range_set_unittest.cc",
"test/run_all_unittests.cc",
"thumbnail_unittest.cc",
"ui/file_name_unittest.cc",
"ui/format_page_size_unittest.cc",
"ui/thumbnail_unittest.cc",
]

configs += [
Expand Down
2 changes: 1 addition & 1 deletion pdf/out_of_process_instance.cc
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
#include "pdf/ppapi_migration/input_event_conversions.h"
#include "pdf/ppapi_migration/url_loader.h"
#include "pdf/ppapi_migration/value_conversions.h"
#include "pdf/thumbnail.h"
#include "pdf/ui/format_page_size.h"
#include "pdf/ui/thumbnail.h"
#include "ppapi/c/dev/ppb_cursor_control_dev.h"
#include "ppapi/c/pp_errors.h"
#include "ppapi/c/private/ppb_pdf.h"
Expand Down
2 changes: 1 addition & 1 deletion pdf/pdfium/pdfium_engine_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include "pdf/ppapi_migration/input_event_conversions.h"
#include "pdf/test/test_client.h"
#include "pdf/test/test_document_loader.h"
#include "pdf/thumbnail.h"
#include "pdf/ui/thumbnail.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/geometry/point.h"
Expand Down
2 changes: 1 addition & 1 deletion pdf/pdfium/pdfium_page.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#include "pdf/pdfium/pdfium_engine.h"
#include "pdf/pdfium/pdfium_unsupported_features.h"
#include "pdf/ppapi_migration/geometry_conversions.h"
#include "pdf/thumbnail.h"
#include "pdf/ui/thumbnail.h"
#include "ppapi/c/private/ppb_pdf.h"
#include "printing/units.h"
#include "third_party/pdfium/public/cpp/fpdf_scopers.h"
Expand Down
2 changes: 1 addition & 1 deletion pdf/pdfium/pdfium_page_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include "pdf/pdfium/pdfium_test_base.h"
#include "pdf/ppapi_migration/geometry_conversions.h"
#include "pdf/test/test_client.h"
#include "pdf/thumbnail.h"
#include "pdf/ui/thumbnail.h"
#include "ppapi/c/private/ppb_pdf.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/pdfium/public/fpdf_formfill.h"
Expand Down
4 changes: 2 additions & 2 deletions pdf/ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ This directory contains utilities for supporting PDF Viewer features other than
the main content area.

TODO(crbug.com/1184342): Accordingly move more code into this directory. For
instance, code that supports the document properties dialog and thumbnails
belong in this directory.
instance, code that supports the document properties dialog belong in this
directory.
2 changes: 1 addition & 1 deletion pdf/thumbnail.cc → pdf/ui/thumbnail.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "pdf/thumbnail.h"
#include "pdf/ui/thumbnail.h"

#include <algorithm>
#include <cmath>
Expand Down
6 changes: 3 additions & 3 deletions pdf/thumbnail.h → pdf/ui/thumbnail.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef PDF_THUMBNAIL_H_
#define PDF_THUMBNAIL_H_
#ifndef PDF_UI_THUMBNAIL_H_
#define PDF_UI_THUMBNAIL_H_

#include "third_party/skia/include/core/SkBitmap.h"

Expand Down Expand Up @@ -38,4 +38,4 @@ class Thumbnail final {

} // namespace chrome_pdf

#endif // PDF_THUMBNAIL_H_
#endif // PDF_UI_THUMBNAIL_H_
2 changes: 1 addition & 1 deletion pdf/thumbnail_unittest.cc → pdf/ui/thumbnail_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "pdf/thumbnail.h"
#include "pdf/ui/thumbnail.h"

#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/geometry/size.h"
Expand Down

0 comments on commit ccff942

Please sign in to comment.