This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
feat: add support for filtering using excluding windows #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for excluding certain windows while capturing a display.
Why do we need this change?
We want the ability to ignore certain windows ( like the camera, cropper etc ) when capturing screen using Helmer
How are we doing this change?
excludingWindows
param usinginit
. To achieve this we also make the corresponding changes inobjc
files.CapturableContent
to also return the list of windows to be excluded.with_display
func to take a list of windows to be excluded. This list is then propogated forward and used while creating a stream to capture.id()
func on thewindow
object to make it easier to get the ids of windows to be excluded.What improvements can be done?
excluding_windows
fetching logic to only loop throughwindows
once.How has this been tested