Modernize node version matrix #2465
Conversation
These are the currently supported versions. Luckily the Windows file path issue was backported to node 20.
| @@ -13,7 +13,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| node: [18.12.0, 20.9.0] | |||
| node: [18.20.5, 20.18.1, 22.12.0, 23.3.0] | |||
There was a problem hiding this comment.
Awesome work!! It would be better to have a
canary in the coal mine to spot future breakage.
| node: [18.20.5, 20.18.1, 22.12.0, 23.3.0] | |
| node: [18.20.5, 20.18.1, 22.12.0, latest] |
There was a problem hiding this comment.
Hmm only when we push though. I wish I'd pinned more versions in the prebuild scripts because it contributed to random failures.
I think new Node versions are something we have to explicitly do work for rather than something that should start potentially breaking builds. @LinusU any opinions?
Sorry about your other PR, I looked for existing ones but somehow still missed it.
There was a problem hiding this comment.
My sense with latest is that there is a chance that CI tells us we have a problem before end users complain and that the non-latest jobs assure us that only the bleed-edge end users are seeing those problems.
|
Please finalize the testing and create a new release. On the |
These are the currently supported versions. Luckily the Windows file path issue was backported to node 20.