Add Feature Detection #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
requested review from
oguzkocer and
crazytonyli
and removed request for
oguzkocer
jkmassel
commented
Sep 15, 2025
| #[derive(Debug, Deserialize)] | ||
| pub struct OptionStringVecOrString { | ||
| #[serde(deserialize_with = "deserialize_string_vec_or_string_as_option")] | ||
| #[serde(default)] |
There was a problem hiding this comment.
I don't really like that we need this line, but I couldn't think of an easy way to avoid it.
jkmassel
force-pushed
the
add/feature-detection
branch
2 times, most recently
from
eadb4d3 to
6df7ae7
Compare
crazytonyli
reviewed
Sep 17, 2025
| #[serde(deserialize_with = "deserialize_string_vec_or_string_as_option")] | ||
| #[serde(default)] | ||
| pub r#type: Option<Vec<String>>, | ||
| pub r#enum: Option<Vec<String>>, |
There was a problem hiding this comment.
What does the r# mean?
There was a problem hiding this comment.
type and enum are reserved terms, so you need to do this to use them as field names
There was a problem hiding this comment.
jkmassel
force-pushed
the
add/feature-detection
branch
from
6df7ae7 to
71376df
Compare
crazytonyli
approved these changes
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to detect namespace and endpoint registration. This makes it possible for applications to answer questions like:
I debated whether to implement something like
ApiDetails::supports(WpSiteFeature::ApplicationPasswords)but this seems like an application-level concern, not a library one. That means some code duplication, but I think it's preferable, because an application will have a better idea of what features it cares about.This PR spawned Automattic/jetpack#45186