Phan: functionify and statusify exit() and die() (#41167)

* non-CRM: exit → exit( 0 )

* CRM: exit → exit( 0 )

* non-CRM: exit() → exit( 0 )

* CRM: exit() → exit( 0 )

* die → die(0)

* Suppress invalid Phan error on valid tests

* die() → die(0)

* Add changelogs

* Suppress unneeded suppression warnings on PHP 8.2

* Oops

* Rework code to satisfy Phan bug

* Remove redundant exits

* Correct PHPDoc

* Update baseline

* Remove comments

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12871434613

Upstream-Ref: Automattic/jetpack@d2c7b02

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 This is an alpha version! The changes listed here are not final.
 
 ### Changed
+- Code: Use function-style exit() and die() with a default status code of 0.
 - Updated package dependencies.
 
 ## [2.0.0] - 2025-01-10

inc/delete-cache-button.php

@@ -132,7 +132,7 @@ function wpsc_admin_bar_delete_cache() {
 		} else {
 			wp_safe_redirect( esc_url_raw( home_url( $req_path ) ) );
 		}
-		exit;
+		exit( 0 );
 	} else {
 		die( "Oops. Problem with nonce. Please delete cached page from settings page." );
 	}

wp-cache-phase2.php

@@ -321,15 +321,15 @@ function wp_cache_serve_cache_file() {
 				if ( $remote_mod_time !== null && $remote_mod_time == $local_mod_time ) {
 					wp_cache_debug( 'wp_cache_serve_cache_file: Send 304 Not Modified header.' );
 					header( $_SERVER['SERVER_PROTOCOL'] . ' 304 Not Modified' );
-					exit();
+					exit( 0 );
 				} else {
 					wp_cache_debug( 'wp_cache_serve_cache_file: 304 browser caching not possible as timestamps differ.' );
 				}
 				header( 'Last-Modified: ' . $local_mod_time );
 			}
 
 			echo $cachefiledata;
-			exit();
+			exit( 0 );
 		} else {
 			wp_cache_debug( 'No wp-cache file exists. Must generate a new one.' );
 			return false;
@@ -404,7 +404,7 @@ function wp_cache_serve_cache_file() {
 	// phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- this is the cached version of the current page. It will have been escaped already.
 	echo $cache;
 	wp_cache_debug( 'exit request', 5 );
-	die();
+	die( 0 );
 }
 
 function wp_cache_get_legacy_cache( $cache_file ) {
@@ -1259,7 +1259,7 @@ function wpsc_create_debug_log( $filename = '', $username = '' ) {
 	header( "WWW-Authenticate: Basic realm=\"WP-Super-Cache Debug Log\"" );
 	header( $_SERVER[ "SERVER_PROTOCOL" ] . " 401 Unauthorized" );
 	echo "You must login to view the debug log";
-	exit;
+	exit( 0 );
 }' . PHP_EOL;
 
 	$fp = fopen( $cache_path . 'view_' . $wp_cache_debug_log, 'w' );

wp-cache.php

@@ -2079,7 +2079,7 @@ function wpsc_config_file_notices() {
 function wpsc_dismiss_indexhtml_warning() {
 		check_ajax_referer( "wpsc-index-dismiss" );
 		update_site_option( 'wp_super_cache_index_detected', 3 );
-		die();
+		die( 0 );
 }
 add_action( 'wp_ajax_wpsc-index-dismiss', 'wpsc_dismiss_indexhtml_warning' );