-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync SDK with AVS API to v1.3.0 #66
Conversation
@chrisli30 Please review. All test are passed now on local dev. I need to fix the test for staging env. |
@@ -76,7 +76,8 @@ describe("getWorkflows Tests", () => { | |||
const countFirstPage = 1; | |||
|
|||
// Isolated test of this account | |||
const wallet = await client.getWallet({ salt: parseInt(process.env.RUN_ID || '112323') }); | |||
const salt = (new Date().getTime() * 1000000000) + Math.floor(Math.random() * 100000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This salt is to gurantee that this salt is 100% unique so that none of our 2 tests writing data to this wallets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks no problem 👌
This PR add 3 things to sync with features that AVS support on
https://github.com/AvaProtocol/EigenLayer-AVS/releases/tag/v1.3.0
Fixes #62 #64