Skip to content

Commit

Permalink
fix(inlinePositioning): infinite loop (atomiks#994)
Browse files Browse the repository at this point in the history
  • Loading branch information
atomiks authored Oct 29, 2021
1 parent 8d50a3c commit 3598727
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion src/plugins/inlinePositioning.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const inlinePositioning: InlinePositioning = {
let placement: Placement;
let cursorRectIndex = -1;
let isInternalUpdate = false;
let triedPlacements: Array<string> = [];

const modifier: Modifier<
'tippyInlinePositioning',
Expand All @@ -40,7 +41,15 @@ const inlinePositioning: InlinePositioning = {
phase: 'afterWrite',
fn({state}) {
if (isEnabled()) {
if (placement !== state.placement) {
if (triedPlacements.indexOf(state.placement) !== -1) {
triedPlacements = [];
}

if (
placement !== state.placement &&
triedPlacements.indexOf(state.placement) === -1
) {
triedPlacements.push(state.placement);
instance.setProps({
// @ts-ignore - unneeded DOMRect properties
getReferenceClientRect: () =>
Expand Down

0 comments on commit 3598727

Please sign in to comment.