Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scanning resources under a management group #350 #352

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

cmendible
Copy link
Member

Description

Enabled scanning resources under a management group

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #350

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

Copy link
Member Author

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmendible cmendible requested a review from Copilot February 12, 2025 16:13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • go.mod: Language not supported
  • internal/scanners/subscriptions.go: Evaluated as low risk
Comments suppressed due to low confidence (1)

cmd/azqr/scan.go:44

  • The new functionality introduced by the 'management-group-id' flag is not covered by tests. Please add tests to ensure that scanning resources under a management group works as expected.
managementGroupID, _ := cmd.Flags().GetString("management-group-id")
@cmendible cmendible merged commit 2e9c682 into main Feb 12, 2025
13 checks passed
@cmendible cmendible deleted the feat-350 branch February 12, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Management Group as a starting point
1 participant