Skip to content

[Az.PurviewData] update generation tool version: autorest.powershell v3 -> v4 #27876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lijinpei2008
Copy link
Contributor

@lijinpei2008 lijinpei2008 commented May 30, 2025

The service team failed to provide a valid unit test, please ignore the items related to testing.
The content of the changelog is consistent with the PR shared below, so it will be updated in the PR below:
#27871

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@lijinpei2008 lijinpei2008 changed the title [Az.PurviewData] update generation tool version: autorest.powershell v3… [Az.PurviewData] update generation tool version: autorest.powershell v3 -> v4 May 30, 2025
@lijinpei2008 lijinpei2008 marked this pull request as ready for review May 30, 2025 06:36
@Copilot Copilot AI review requested due to automatic review settings May 30, 2025 06:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Regenerates the Az.Purview module with autorest.powershell v4, updating cmdlet help, manifest metadata, and the solution configuration.

  • Refreshed all help/*.md files: removed obsolete -Kind params, changed parameter types to String, adjusted output model references, and normalized online URLs.
  • Updated Az.Purview.psd1: bumped generation date, upgraded Az.Accounts requirement, added new Update-* cmdlets, and fixed path separators.
  • Revised Purview.sln: inserted the new purviewdata project entry and expanded solution platform configurations for x64/x86.

Reviewed Changes

Copilot reviewed 401 out of 401 changed files in this pull request and generated 1 comment.

File Description
src/Purview/Purview/help/*.md Help topics regenerated: syntax updated, types set to String, output models simplified, URLs lowercased
src/Purview/Purview/Az.Purview.psd1 Module manifest bumped date, dependency version, added update cmdlets, path separator normalization
src/Purview/Purview.sln Added purviewdata project and x64/x86 Debug/Release configurations
Comments suppressed due to low confidence (4)

src/Purview/Purview/help/New-AzPurviewAdlsGen1ScanRulesetObject.md:18

  • Switching the file extension parameter from a specific enum type to a plain String[] removes compile-time validation; consider retaining the enum for stricter input validation.
[-ScanningRuleFileExtension <String[]>]

src/Purview/Purview/help/New-AzPurviewAdlsGen1ScanRulesetObject.md:4

  • [nitpick] Lowercasing the cmdlet in the online URL may diverge from established URL conventions; verify that the new link resolves correctly and consider matching existing casing patterns.
+online version: https://learn.microsoft.com/powershell/module/Az.Purview/new-azpurviewadlsgen1scanrulesetobject

src/Purview/Purview/Az.Purview.psd1:67

  • [nitpick] Using forward slashes in PSD1 paths may not be supported on all platforms; consider using backslashes or a path-building function to ensure cross-platform compatibility.
+FormatsToProcess = 'Purview.Autorest/Az.Purview.format.ps1xml',

src/Purview/Purview/Purview.sln:31

  • [nitpick] Adding explicit x64/x86 configurations duplicates the existing Any CPU settings and increases maintenance overhead; consider consolidating or removing redundant solution platforms.
+	Debug|x64 = Debug|x64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant