deb: Fix patches when patch is in subdir #543
Merged
+52
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a patch is in a subdir, the wrong path was used to extract the patch from the source from. Additionally, the call to `mountSources` was causing issues afer this fix. `mountSources` is just in this case is an optimization so to prevent dpkg-source from having to re-extract data we already have available. Since this is causing an issue I decided to just remove it for now. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
fix_deb_patches
branch
from
90afdb0 to
f5ac2a0
Compare
DannyBrito
reviewed
Feb 28, 2025
DannyBrito
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a patch is in a subdir, the wrong path was used to extract the
patch from the source from.
Additionally, the call to
mountSourceswas causing issues afer thisfix.
mountSourcesis just in this case is an optimization so to preventdpkg-source from having to re-extract data we already have available.
Since this is causing an issue I decided to just remove it for now.
I believe the two changes included in this PR are playing off each other (ie, one change requires a change in the other).
We'll need to look into this before including this optimization again.