Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service bus managed identity integration #253

Merged
merged 8 commits into from
Sep 6, 2024
Merged

Conversation

mjrousos
Copy link
Member

Updates the ACA KEDA scale rule to authenticate with Azure Service Bus using managed identity. This also allows disabling local auth for the Service Bus instance.

Note that the ACA AVM doesn't yet support this feature, so we need to use our own ACA module instead of AVM.

@mjrousos mjrousos requested a review from twsouthwick August 29, 2024 19:33
@mjrousos
Copy link
Member Author

mjrousos commented Sep 5, 2024

@twsouthwick - Any feedback on this one?

Copy link
Contributor

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

infra/core/hosting/container-app.bicep Show resolved Hide resolved
@mjrousos mjrousos merged commit f8af48d into Azure:main Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants