Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added RBAC to KeyVault and updated secret initializer #64

Merged
merged 4 commits into from
Mar 8, 2023
Merged

added RBAC to KeyVault and updated secret initializer #64

merged 4 commits into from
Mar 8, 2023

Conversation

kwkraus
Copy link
Contributor

@kwkraus kwkraus commented Mar 7, 2023 •
edited
Loading

@kwkraus kwkraus marked this pull request as ready for review March 8, 2023 18:40
KSchlobohm
KSchlobohm requested changes Mar 8, 2023
View reviewed changes
infra/createAppRegistrations.ps1 Show resolved Hide resolved
infra/main.parameters.json Outdated Show resolved Hide resolved
infra/resources.bicep Outdated Show resolved Hide resolved
KSchlobohm
KSchlobohm approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@KSchlobohm KSchlobohm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KSchlobohm KSchlobohm merged commit 9da4b15 into Azure:main Mar 8, 2023
@kwkraus kwkraus deleted the keyvaultrbac branch March 8, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSchlobohm KSchlobohm KSchlobohm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwkraus @KSchlobohm