Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msal-node bug fix: acquireTokenSilent doesn't look in persistent cache #7469

Draft
wants to merge 29 commits into
base: dev
Choose a base branch
from

Conversation

shylasummers
Copy link
Contributor

Fixed a bug in msal-node where acquireTokenSilent doesn't look in the persistent cache for a token if a valid token is not present in the in-memory cache.

  • With the bug, if a valid token is not found in the in-memory cache, msal-node will make a network request
  • With the fix, if a valid token is not present in the in-memory cache and a persistent cache is present, msal-node will overwrite the in-memory cache with the persistent cache and search for the token there before making a network request. This also keeps the in-memory cache in sync with the persistent cache

@github-actions github-actions bot added samples Related to the samples apps for the library. msal-node Related to msal-node package msal-common Related to msal-common package labels Dec 16, 2024
@github-actions github-actions bot added the documentation Related to documentation. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-common Related to msal-common package msal-node Related to msal-node package samples Related to the samples apps for the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants