feature flag it!

BBhelp · Jul 30, 2019 · 7308e6a · 7308e6a
1 parent 0e22276
commit 7308e6a
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 11 deletions.
diff --git a/app/src/lib/feature-flag.ts b/app/src/lib/feature-flag.ts
@@ -101,3 +101,7 @@ export function enableWSLDetection(): boolean {
 export function enableBranchProtectionWarningFlow(): boolean {
   return enableBranchProtectionChecks() && enableDevelopmentFeatures()
 }
+
+export function enableHideWhitespaceInDiffOption(): boolean {
+  return enableBetaFeatures()
+}
diff --git a/app/src/lib/stores/app-store.ts b/app/src/lib/stores/app-store.ts
@@ -220,6 +220,7 @@ import {
   enableStashing,
   enableBranchProtectionChecks,
   enableBranchProtectionWarningFlow,
+  enableHideWhitespaceInDiffOption,
 } from '../feature-flag'
 import { Banner, BannerType } from '../../models/banner'
 import * as moment from 'moment'
@@ -1262,7 +1263,7 @@ export class AppStore extends TypedBaseStore<IAppState> {
       repository,
       file,
       sha,
-      this.hideWhitespaceInDiff
+      enableHideWhitespaceInDiffOption() ? this.hideWhitespaceInDiff : false
     )
 
     const stateAfterLoad = this.repositoryStateCache.get(repository)

diff --git a/app/src/ui/history/commit-summary.tsx b/app/src/ui/history/commit-summary.tsx
@@ -11,6 +11,7 @@ import { getAvatarUsersForCommit, IAvatarUser } from '../../models/avatar'
 import { AvatarStack } from '../lib/avatar-stack'
 import { CommitAttribution } from '../lib/commit-attribution'
 import { Checkbox, CheckboxValue } from '../lib/checkbox'
+import { enableHideWhitespaceInDiffOption } from '../../lib/feature-flag'
 
 interface ICommitSummaryProps {
   readonly repository: Repository
@@ -351,16 +352,17 @@ export class CommitSummary extends React.Component<
 
               {filesDescription}
             </li>
-
-            <Checkbox
-              label="Hide Whitespace"
-              value={
-                this.props.hideWhitespaceInDiff
-                  ? CheckboxValue.On
-                  : CheckboxValue.Off
-              }
-              onChange={this.onHideWhitespaceInDiffChanged}
-            />
+            {enableHideWhitespaceInDiffOption() && (
+              <Checkbox
+                label="Hide Whitespace"
+                value={
+                  this.props.hideWhitespaceInDiff
+                    ? CheckboxValue.On
+                    : CheckboxValue.Off
+                }
+                onChange={this.onHideWhitespaceInDiffChanged}
+              />
+            )}
           </ul>
         </div>