Remove as many warnings as we can by initialising @Ivars to nil [cucu…

…mber#507 state:resolved]

History.txt

@@ -5,6 +5,7 @@
 * Avoid duplicate cucumber entries in database.yml (Daniel Hofstetter)
 
 === Changed Features
+* $cucumber_interrupted is now Cucumber.wants_to_quit - avoid global variable, which gives warnings. (Aslak Hellesøy)
 * Examples keyword without a colon is deprecated loudly. Gherkin will not recognize it at all. (Gherkin #30 Mike Sassak)
 
 == 0.4.3 2009-10-28

lib/cucumber.rb

@@ -7,3 +7,9 @@
 require 'cucumber/step_mother'
 require 'cucumber/cli/main'
 require 'cucumber/broadcaster'
+
+module Cucumber
+  class << self
+    attr_accessor :wants_to_quit
+  end
+end

lib/cucumber/ast/background.rb

@@ -23,7 +23,7 @@ def step_collection(step_invocations)
       end
 
       def accept(visitor)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         visitor.visit_comment(@comment) unless @comment.empty?
         visitor.visit_background_name(@keyword, @name, file_colon_line(@line), source_indent(first_line_length))
         with_visitor(hook_context, visitor) do

lib/cucumber/ast/comment.rb

@@ -17,7 +17,7 @@ def empty?
       end
 
       def accept(visitor)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         @value.strip.split("\n").each do |line|
           visitor.visit_comment_line(line.strip)
         end

lib/cucumber/ast/examples.rb

@@ -6,7 +6,7 @@ def initialize(comment, line, keyword, name, outline_table)
       end
 
       def accept(visitor)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         visitor.visit_comment(@comment) unless @comment.empty?
         visitor.visit_examples_name(@keyword, @name)
         visitor.visit_outline_table(@outline_table)

lib/cucumber/ast/feature.rb

@@ -16,7 +16,7 @@ def initialize(background, comment, tags, name, feature_elements)
       end
 
       def accept(visitor)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         visitor.visit_comment(@comment) unless @comment.empty?
         visitor.visit_tags(@tags)
         visitor.visit_feature_name(@name)

lib/cucumber/ast/features.rb

@@ -23,7 +23,7 @@ def add_feature(feature)
       end
 
       def accept(visitor)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         start = Time.now
         self.each do |feature|
           visitor.visit_feature(feature)

lib/cucumber/ast/outline_table.rb

@@ -9,7 +9,7 @@ def initialize(raw, scenario_outline)
       end
 
       def accept(visitor)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         cells_rows.each_with_index do |row, n|
           if(visitor.options[:expand])
             row.accept(visitor)
@@ -44,7 +44,7 @@ def visit_scenario_name(visitor, row)
         @scenario_outline.visit_scenario_name(visitor, row)
       end
 
-      class ExampleRow < Cells #:nodoc:
+      class ExampleRow < Cells #:nodoc:        
         class InvalidForHeaderRowError < NoMethodError
           def initialize(*args)
             super 'This is a header row and cannot pass or fail'
@@ -53,6 +53,11 @@ def initialize(*args)
 
         attr_reader :scenario_outline # https://rspec.lighthouseapp.com/projects/16211/tickets/342
 
+        def initialize(table, cells)
+          super
+          @scenario_exception = nil
+        end
+
         def create_step_invocations!(scenario_outline)
           @scenario_outline = scenario_outline
           @step_invocations = scenario_outline.step_invocations(self)
@@ -65,7 +70,7 @@ def skip_invoke!
         end
 
         def accept(visitor)
-          return if $cucumber_interrupted
+          return if Cucumber.wants_to_quit
           visitor.options[:expand] ? accept_expand(visitor) : accept_plain(visitor)
         end
 

lib/cucumber/ast/py_string.rb

@@ -31,7 +31,7 @@ def to_s
       end
 
       def accept(visitor)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         visitor.visit_py_string(to_s)
       end
 

lib/cucumber/ast/scenario.rb

@@ -29,10 +29,12 @@ def initialize(background, comment, tags, line, keyword, name, steps)
         step_invocations = steps.map{|step| step.step_invocation}
         @steps = @background.step_collection(step_invocations)
         @background.feature_elements << self
+
+        @exception = @executed = nil
       end
 
       def accept(visitor)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
 
         with_visitor(visitor) do
           visitor.visit_comment(@comment) unless @comment.empty?

lib/cucumber/ast/scenario_outline.rb

@@ -5,7 +5,7 @@ class ScenarioOutline #:nodoc:
 
       module ExamplesArray #:nodoc:
         def accept(visitor)
-          return if $cucumber_interrupted
+          return if Cucumber.wants_to_quit
           each do |examples|
             visitor.visit_examples(examples)
           end
@@ -39,7 +39,7 @@ def initialize(background, comment, tags, line, keyword, name, steps, example_se
       end
 
       def accept(visitor)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         visitor.visit_comment(@comment) unless @comment.empty?
         visitor.visit_tags(@tags)
         visitor.visit_scenario_name(@keyword, @name, file_colon_line(@line), source_indent(first_line_length))

lib/cucumber/ast/step.rb

@@ -38,7 +38,7 @@ def step_invocation_from_cells(cells)
       end
 
       def accept(visitor)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         # The only time a Step is visited is when it is in a ScenarioOutline.
         # Otherwise it's always StepInvocation that gets visited instead.
         visit_step_result(visitor, first_match(visitor), @multiline_arg, :skipped, nil, nil)

lib/cucumber/ast/step_collection.rb

@@ -10,7 +10,7 @@ def initialize(steps)
       end
 
       def accept(visitor, &proc)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         @steps.each do |step|
           visitor.visit_step(step) if proc.nil? || proc.call(step)
         end

lib/cucumber/ast/step_invocation.rb

@@ -22,6 +22,7 @@ def worst_status(statuses)
       def initialize(step, name, multiline_arg, matched_cells)
         @step, @name, @multiline_arg, @matched_cells = step, name, multiline_arg, matched_cells
         status!(:skipped)
+        @skip_invoke = @exception = @step_match = @different_table = @reported_exception = @background = nil
       end
 
       def background?
@@ -33,7 +34,7 @@ def skip_invoke!
       end
 
       def accept(visitor)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         invoke(visitor.step_mother, visitor.options)
         visit_step_result(visitor)
       end

lib/cucumber/ast/table.rb

@@ -148,7 +148,7 @@ def each_cells_row(&proc) #:nodoc:
       end
 
       def accept(visitor) #:nodoc:
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         cells_rows.each do |row|
           visitor.visit_table_row(row)
         end
@@ -567,7 +567,7 @@ def initialize(table, cells)
         end
 
         def accept(visitor)
-          return if $cucumber_interrupted
+          return if Cucumber.wants_to_quit
           each do |cell|
             visitor.visit_table_cell(cell)
           end
@@ -623,7 +623,7 @@ def initialize(value, table, line)
         end
 
         def accept(visitor)
-          return if $cucumber_interrupted
+          return if Cucumber.wants_to_quit
           visitor.visit_table_cell_value(value, status)
         end
 

lib/cucumber/ast/tags.rb

@@ -87,7 +87,7 @@ def initialize(line, tag_names)
       end
 
       def accept(visitor)
-        return if $cucumber_interrupted
+        return if Cucumber.wants_to_quit
         @tag_names.each do |tag_name|
           visitor.visit_tag_name(tag_name)
         end

lib/cucumber/cli/main.rb

@@ -29,6 +29,7 @@ def initialize(args, out_stream = STDOUT, error_stream = STDERR)
         @args         = args
         @out_stream   = out_stream == STDOUT ? Formatter::ColorIO.new : out_stream
         @error_stream = error_stream
+        @configuration = nil
       end
 
       def execute!(step_mother)
@@ -110,8 +111,8 @@ def enable_diffing
 
       def trap_interrupt
         trap('INT') do
-          exit!(1) if $cucumber_interrupted
-          $cucumber_interrupted = true
+          exit!(1) if Cucumber.wants_to_quit
+          Cucumber.wants_to_quit = true
           STDERR.puts "\nExiting... Interrupt again to exit immediately."
         end
       end

lib/cucumber/cli/options.rb

@@ -60,7 +60,9 @@ def initialize(out_stream = STDOUT, error_stream = STDERR, options = {})
         @skip_profile_information = options[:skip_profile_information]
         @profiles = []
         @overridden_paths = []
-        @options        = default_options
+        @options = default_options
+
+        @quiet = @disable_profile_loading = nil
       end
 
       def [](key)

lib/cucumber/cli/profile_loader.rb

@@ -3,6 +3,10 @@ module Cli
 
     class ProfileLoader
 
+      def initialize
+        @cucumber_yml = nil
+      end
+
       def args_from(profile)
         unless cucumber_yml.has_key?(profile)
           raise(ProfileNotFound, <<-END_OF_ERROR)

lib/cucumber/parser/natural_language.rb

@@ -18,6 +18,7 @@ def initialize(step_mother, lang)
         raise "Language not supported: #{lang.inspect}" if @keywords.nil?
         @keywords['grammar_name'] = @keywords['name'].gsub(/\s/, '')
         register_adverbs(step_mother) if step_mother
+        @parser = nil
       end
 
       def register_adverbs(step_mother)

lib/cucumber/rb_support/rb_language.rb

@@ -35,6 +35,7 @@ def initialize(step_mother)
         @step_mother = step_mother
         @step_definitions = []
         RbDsl.rb_language = self
+        @world_proc = @world_modules = nil
       end
 
       # Tell the language about other i18n translations so that

lib/cucumber/step_mother.rb

@@ -49,6 +49,7 @@ def initialize
       @programming_languages = []
       @language_map = {}
       load_natural_language('en')
+      @current_scenario = nil
     end
 
     def load_plain_text_features(feature_files)