Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POLIO-1842: Supply Chain: VAR saving error #1959

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

beygorghor
Copy link
Collaborator

@beygorghor beygorghor commented Feb 6, 2025

Copy pasting doses received on a new VAR is not validating form

Related JIRA tickets :POLIO-1842

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

Replace multiple setFieldValue with one setValues to avoid multiple state changes

How to test

Follow the first video while editing a supply chain for a country

Print screen / video

Screen.Recording.2025-02-06.at.15.24.52.mov

Notes

Things that the reviewers should know:

  • known bugs that are out of the scope of the PR
  • other trade-offs that were made
  • does the PR depends on a PR in bluesquare-components?
  • should the PR be merged into another PR?

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

@beygorghor beygorghor added the release Should be released in production at next deploy label Feb 6, 2025
Copy link
Member

@quang-le quang-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONVENTIONAL COMMIT! 😄

@beygorghor beygorghor merged commit 642ec8d into main Feb 7, 2025
3 checks passed
@beygorghor beygorghor deleted the POLIO-1842-var-save-bug branch February 7, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Should be released in production at next deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants